From: Johannes Berg <johannes@sipsolutions.net>
To: Alina Friedrichsen <x-alina@gmx.net>
Cc: openwrt-devel@lists.openwrt.org, linux-wireless@vger.kernel.org,
berlin@berlin.freifunk.net
Subject: Re: mac80211 (ath9k, ath5k, etc.) set BSSID Patch
Date: Tue, 30 Dec 2008 23:40:11 +0100 [thread overview]
Message-ID: <1230676811.3850.22.camel@johannes> (raw)
In-Reply-To: <20081230223611.163110@gmx.net> (sfid-20081230_233642_601178_E4AB42EE)
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
Hi Alina,
> > please use a bool for that
>
> Yes, but the called function is written in the old C style before C99, so I think I should use the same type.
I disagree, even if the function doesn't use the proper types
pervasively, we shouldn't be adding old-style stuff.
What Jouni pointed out still stands, you should separate the bugfix and
the 'disregard ibss join' feature into two patches.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-12-30 22:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 2:56 mac80211 (ath9k, ath5k, etc.) set BSSID Patch Alina Friedrichsen
2008-12-30 10:39 ` Johannes Berg
2008-12-30 22:36 ` Alina Friedrichsen
2008-12-30 22:40 ` Johannes Berg [this message]
2008-12-30 23:07 ` Alina Friedrichsen
2009-01-01 22:41 ` mac80211 (ath9k, ath5k, etc.) set fixed BSSID + channel Patch Alina Friedrichsen
2009-01-02 14:29 ` Johannes Berg
2008-12-30 11:37 ` mac80211 (ath9k, ath5k, etc.) set BSSID Patch Jouni Malinen
2008-12-30 16:15 ` Alina Friedrichsen
2008-12-30 16:56 ` Jouni Malinen
2008-12-30 21:20 ` Alina Friedrichsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230676811.3850.22.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=berlin@berlin.freifunk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=openwrt-devel@lists.openwrt.org \
--cc=x-alina@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).