From: Johannes Berg <johannes@sipsolutions.net>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Jouni.Malinen@Atheros.com
Subject: Re: [PATCH v2] mac80211: Add 802.11h CSA support
Date: Mon, 05 Jan 2009 14:10:40 +0100 [thread overview]
Message-ID: <1231161041.3334.8.camel@johannes> (raw)
In-Reply-To: <18785.54821.934672.713597@gargle.gargle.HOWL>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
On Mon, 2009-01-05 at 15:13 +0530, Sujith wrote:
[...]
Looks good to me, just one thought I had:
> + /* Disregard subsequent beacons if we are already running a timer
> + processing a CSA */
> +
> + if (ifsta->flags & IEEE80211_STA_CSA_RECEIVED)
> + return;
Should we verify that we're getting subsequent CSAs? Is it possible that
an AP drops the CSA element again and expects STAs to _not_ switch in
that case? Or, even if that is not possible, should we verify that
anyway?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-01-05 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 9:43 [PATCH v2] mac80211: Add 802.11h CSA support Sujith
2009-01-05 13:10 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231161041.3334.8.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=Jouni.Malinen@Atheros.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox