From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
Daniel Drake <dsd@gentoo.org>, Tomas Winkler <tomasw@gmail.com>,
Javier Cardona <javier@cozybit.com>, Chr <chunkeey@web.de>
Subject: Re: drivers returning wrong results from their _tx op
Date: Tue, 06 Jan 2009 14:00:59 +0100 [thread overview]
Message-ID: <1231246859.3503.0.camel@johannes> (raw)
In-Reply-To: <b6c5339f0901051424q12d8fc14o8f20b62cfacc4e6e@mail.gmail.com> (sfid-20090105_232440_694283_0A261787)
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Mon, 2009-01-05 at 17:24 -0500, Bob Copeland wrote:
> On Mon, Jan 5, 2009 at 5:07 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > spatch:
> >
> > @ r1 @
> > identifier _tx, _ops;
>
> spatch is very neat...
Yes, indeed, it is, I've used it a few times already :)
> > First off: all those should return NETDEV_TX_OK/BUSY.
> > ath5k: returns 0/-1
>
> Can the kerneldoc for mac80211 ops structure document it?
I guess it should, want to send a patch?
> I'll send a patch for ath5k unless someone beats me to it.
Thanks.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-06 13:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 22:07 drivers returning wrong results from their _tx op Johannes Berg
2009-01-05 22:24 ` Bob Copeland
2009-01-06 13:00 ` Johannes Berg [this message]
2009-01-09 2:23 ` Bob Copeland
2009-01-09 8:13 ` Kalle Valo
2009-01-09 10:06 ` Johannes Berg
2009-01-09 15:44 ` Bob Copeland
2009-01-09 16:17 ` Kalle Valo
2009-01-09 18:27 ` Bob Copeland
2009-01-09 18:47 ` Kalle Valo
2009-01-11 3:12 ` Bob Copeland
2009-01-11 6:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231246859.3503.0.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=chunkeey@web.de \
--cc=dsd@gentoo.org \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).