From: Johannes Berg <johannes@sipsolutions.net>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Jouni Malinen <jmalinen@atheros.com>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@venema.h4ckr.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>,
Christoph Hellwig <hch@infradead.org>,
Sujith Manoharan <Sujith.Manoharan@atheros.com>,
Imre Kaloz <kaloz@openwrt.org>
Subject: Re: [PATCH 04/11] ath9k: introduce bus specific cleanup routine
Date: Wed, 07 Jan 2009 11:24:12 +0100 [thread overview]
Message-ID: <1231323852.3545.22.camel@johannes> (raw)
In-Reply-To: <1231322972-24094-5-git-send-email-juhosg@openwrt.org> (sfid-20090107_111132_955895_E4ACE8AD)
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Wed, 2009-01-07 at 11:09 +0100, Gabor Juhos wrote:
> /* Deinitialize the device */
> - ath_detach(sc);
> - if (to_pci_dev(sc->dev)->irq)
> - free_irq(to_pci_dev(sc->dev)->irq, sc);
> - pci_iounmap(to_pci_dev(sc->dev), sc->mem);
> - pci_release_region(to_pci_dev(sc->dev), 0);
> - pci_disable_device(to_pci_dev(sc->dev));
> - ieee80211_free_hw(sc->hw);
> + ath_bus_cleanup(sc);
And how is ath_detach() or ieee80211_free_hw() bus specific? That should
not be in the bus specific function.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-07 10:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 10:09 [PATCH 00/11] ath9k: add preliminary support for the AR913x SoCs Gabor Juhos
2009-01-07 10:09 ` [PATCH 01/11] ath9k: convert to struct device Gabor Juhos
2009-01-07 10:09 ` [PATCH 02/11] ath9k: convert to use bus-agnostic DMA routines Gabor Juhos
2009-01-07 10:09 ` [PATCH 03/11] ath9k: introduce bus specific cache size routine Gabor Juhos
2009-01-07 10:09 ` [PATCH 04/11] ath9k: introduce bus specific cleanup routine Gabor Juhos
2009-01-07 10:24 ` Johannes Berg [this message]
2009-01-07 17:34 ` Gabor Juhos
2009-01-07 10:27 ` Johannes Berg
2009-01-07 10:09 ` [PATCH 05/11] ath9k: move PCI code into separate file Gabor Juhos
2009-01-07 10:09 ` [PATCH 06/11] ath9k: introduce platform driver for AHB bus support Gabor Juhos
2009-01-07 10:09 ` [PATCH 07/11] ath9k: get EEPROM contents from platform data on AHB bus Gabor Juhos
2009-01-07 10:09 ` [PATCH 08/11] ath9k: enable support for AR9100 Gabor Juhos
2009-01-07 10:29 ` Johannes Berg
2009-01-07 14:37 ` Gabor Juhos
2009-01-07 10:09 ` [PATCH 09/11] ath9k: remove (u16) casts from rtc register access Gabor Juhos
2009-01-07 10:09 ` [PATCH 10/11] ath9k: fix ar5416Addac_9100 values Gabor Juhos
2009-01-07 10:09 ` [PATCH 11/11] ath9k: fix null pointer dereference in ani monitor code Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231323852.3545.22.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=Sujith.Manoharan@atheros.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=hch@infradead.org \
--cc=jmalinen@atheros.com \
--cc=juhosg@openwrt.org \
--cc=kaloz@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).