From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@web.de>
Cc: wireless <linux-wireless@vger.kernel.org>,
John W Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] p54: return NETDEV_TX_OK in p54_tx and fix sparse warnings
Date: Wed, 07 Jan 2009 16:46:27 +0100 [thread overview]
Message-ID: <1231343187.3545.46.camel@johannes> (raw)
In-Reply-To: <1231342997.3545.44.camel@johannes> (sfid-20090107_164257_031400_85F402D7)
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
On Wed, 2009-01-07 at 16:43 +0100, Johannes Berg wrote:
> > @@ -1750,7 +1750,7 @@ static int p54_set_ps(struct ieee80211_hw *dev)
> > int i;
> >
> > if (dev->conf.flags & IEEE80211_CONF_PS)
> > - mode = cpu_to_le16(P54_PSM | P54_PSM_DTIM | P54_PSM_MCBC);
> > + mode = P54_PSM | P54_PSM_DTIM | P54_PSM_MCBC;
>
> you also have to declare mode as u16, no?
Sorry, you do, I got confused.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-01-07 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 15:40 [PATCH] p54: return NETDEV_TX_OK in p54_tx and fix sparse warnings Christian Lamparter
2009-01-07 15:43 ` Johannes Berg
2009-01-07 15:46 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231343187.3545.46.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox