Re: drivers returning wrong results from their _tx op

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On Fri, 2009-01-09 at 10:13 +0200, Kalle Valo wrote:

> > @@ -1170,6 +1170,7 @@ enum ieee80211_ampdu_mlme_action {
> >   *	configuration in the TX control data. This handler should,
> >   *	preferably, never fail and stop queues appropriately, more
> >   *	importantly, however, it must never fail for A-MPDU-queues.
> > + *	Returns NETDEV_TX_OK, or NETDEV_TX_BUSY if it fails.
> >   *	Must be implemented and atomic.
> 
> Based on discussion from netdev I have understood that NETDEV_TX_BUSY
> is not recommended, it's better to stop the queue already earlier,
> drop the frame or store the skb somewhere else temporarily. Johannes,
> have I understood this correctly?

Yes. Well, returning BUSY _should_ work, but I'd like to remove it and
the complicated retry logic from mac80211. Only adm8211 really needs it,
afaik, all other drivers can just drop the skb in error conditions,
adm8211 can only transmit one skb at a time so needs this for fragmented
frames which don't adhere to stopping the queue, unfortunately. This I
may change at some time.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]