From: Johannes Berg <johannes@sipsolutions.net>
To: Colin McCabe <colin@cozybit.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: Fix regression in mesh_param input parsing
Date: Sat, 10 Jan 2009 10:14:26 +0100 [thread overview]
Message-ID: <1231578866.3685.5.camel@johannes> (raw)
In-Reply-To: <1231549996-15919-1-git-send-email-colin@cozybit.com> (sfid-20090110_021745_599151_06D1AB57)
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
On Fri, 2009-01-09 at 17:13 -0800, Colin McCabe wrote:
> In the iw tool, don't crash on bad arguments to "iw dev mesh set mesh_param"
>
> ---
> mesh.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/mesh.c b/mesh.c
> index d6edf3f..f663363 100644
> --- a/mesh.c
> +++ b/mesh.c
> @@ -192,9 +192,10 @@ static const struct mesh_param_descr* find_mesh_param(int argc, char **argv,
>
> /* Find out what mesh parameter we want to change. */
> mdescr = NULL;
> - for (i = 0; ARRAY_SIZE(_mesh_param_descrs); i++)
> + for (i = 0; i < ARRAY_SIZE(_mesh_param_descrs); i++) {
> if (!strcmp(_mesh_param_descrs[i].name, argv[0]))
> return _mesh_param_descrs + i;
> + }
Ouch, sorry about that! Merged the patch, thanks.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-01-10 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 1:13 [PATCH] iw: Fix regression in mesh_param input parsing Colin McCabe
2009-01-10 9:14 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231578866.3685.5.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=colin@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox