Re: [RFC] nl80211: New command for adding extra IE(s) into management frames

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

On Mon, 2009-01-12 at 16:26 +0200, Jouni Malinen wrote:

> +	/* Extra IE data for management frames */
> +	u8 *ie_probereq;
> +	size_t ie_probereq_len;
> +	u8 *ie_proberesp;
> +	size_t ie_proberesp_len;
> +	u8 *ie_auth;
> +	size_t ie_auth_len;
> +	u8 *ie_assocreq;
> +	size_t ie_assocreq_len;
> +	u8 *ie_reassocreq;
> +	size_t ie_reassocreq_len;
> +	u8 *ie_deauth;
> +	size_t ie_deauth_len;
> +	u8 *ie_disassoc;
> +	size_t ie_disassoc_len;

It'd be more memory efficient on 64-bit to not alternate between 64 and
32 bit values, but I don't really care too much in this struct.

Should we sanity-check the input? E.g. in nl80211, ensure that it's
(<type><len><data...>)* with <len> being correct and no final padding?
And maybe that there isn't anything in those IEs that we've already
added, like an SSID?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]