From: Dan Williams <dcbw@redhat.com>
To: Andrey Yurovsky <andrey@cozybit.com>
Cc: Colin McCabe <colin@cozybit.com>,
linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org
Subject: Re: [PATCH v3] libertas: if_spi, driver for libertas GSPI devices
Date: Mon, 12 Jan 2009 14:37:52 -0500 [thread overview]
Message-ID: <1231789072.28887.11.camel@localhost.localdomain> (raw)
In-Reply-To: <45e8e6c40901121104r1f55894dy35d7528e8174f036@mail.gmail.com>
On Mon, 2009-01-12 at 11:04 -0800, Andrey Yurovsky wrote:
> Hi Dan, Johannes was correct -- the explicit get_unaligned_ was not
> needed and using packed was required. Unfortunately our patch got
> merged before we had a chance to send a version including just the
> packing, so I'm preparing a patch that reverts the calls to
> get_unaligned_* ...this is, however, independent of the actual
> if_spi.c driver patch.
Yes, they are independent. Alternatively, you could just ask John to
revert the patch, and then provide a new patch with just the 'packed'
bits, which might be cleaner in the git history.
Dan
next prev parent reply other threads:[~2009-01-12 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 22:58 [PATCH v3] libertas: if_spi, driver for libertas GSPI devices Colin McCabe
2009-01-12 14:53 ` Dan Williams
2009-01-12 19:04 ` Andrey Yurovsky
2009-01-12 19:37 ` Dan Williams [this message]
2009-01-12 19:42 ` Andrey Yurovsky
2009-01-12 19:36 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231789072.28887.11.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=andrey@cozybit.com \
--cc=colin@cozybit.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).