From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni.malinen@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: New command for adding extra IE(s) into management frames
Date: Tue, 13 Jan 2009 14:38:57 +0100 [thread overview]
Message-ID: <1231853937.3671.28.camel@johannes> (raw)
In-Reply-To: <20090113115128.GA11245@jm.kir.nu>
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
On Tue, 2009-01-13 at 13:51 +0200, Jouni Malinen wrote:
> + if (params->ies) {
> + ies = kmalloc(params->ies_len, GFP_KERNEL);
> + if (ies == NULL)
> + return -ENOMEM;
> + ies_len = params->ies_len;
> + memcpy(ies, params->ies, ies_len);
kmemdup? Might also make sense to not try the allocation if we're going
to refuse it anyway, but that might be complicated to do and probably
doesn't matter.
Otherwise looks good to me.
Acked-by: Johannes Berg <johannes@sipsolutions.net>
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-13 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 11:51 [PATCH] nl80211: New command for adding extra IE(s) into management frames Jouni Malinen
2009-01-13 13:38 ` Johannes Berg [this message]
2009-01-13 13:49 ` Jouni Malinen
2009-01-13 13:55 ` Johannes Berg
2009-01-13 14:03 ` [PATCHv2] " Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231853937.3671.28.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox