From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: Warning in latest wireless-testing
Date: Wed, 14 Jan 2009 01:06:10 +0100 [thread overview]
Message-ID: <1231891570.28311.0.camel@johannes> (raw)
In-Reply-To: <496D2AE4.7000808@lwfinger.net> (sfid-20090114_005957_740853_8987481F)
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On Tue, 2009-01-13 at 17:59 -0600, Larry Finger wrote:
> In the latest pull from wireless testing, I get the following warning:
>
> CC [M] drivers/net/wireless/b43/main.o
> drivers/net/wireless/b43/main.c: In function ‘b43_op_set_key’:
> drivers/net/wireless/b43/main.c:3636: warning: pointer type mismatch
> in conditional expression
That looks like a merge error:
b43dbg(wl, "%s hardware based encryption for keyidx: %d, "
"mac: %pM\n",
cmd == SET_KEY ? "Using" : "Disabling", key->keyidx,
sta ? sta->addr : "<group key>");
It should be something like
u8 bcast[ETH_ALEN] = {0xff,...}
sta ? sta->addr : bcast
there.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-14 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 23:59 Warning in latest wireless-testing Larry Finger
2009-01-14 0:06 ` Johannes Berg [this message]
2009-01-14 13:33 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231891570.28311.0.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).