Re: [PATCH 08/13] cfg80211: save original values on regulatory hints

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]

On Fri, 2009-01-16 at 08:31 -0800, Luis R. Rodriguez wrote:
> On Fri, Jan 16, 2009 at 01:25:21AM -0800, Johannes Berg wrote:
> > On Thu, 2009-01-15 at 16:12 -0800, Luis R. Rodriguez wrote:
> > > When a driver issues a regulatory_hint() lets save the received
> > > values as original channel settings. This allows users to change
> > > regulatory domains multiple times while always respecting the driver's
> > > own regulatory setings.
> > 
> > This definitely isn't the right way to do things here. This means that
> > my card that's programmed to US can never do channel 13 here, something
> > which on b43 we definitely want to allow.
> 
> Ah -- are you sure you want to allow for that? 

Yes.

> It seems I was misunderstanding a bit
> how things would be done for 11d in ath9k and the fact is that we *don't* allow
> for channels beyond what the programmed regulatory domain allows. This is because
> calibration stuff has only been tested/ensured/certified/call-it-what you want
> for the channels in that regulatory domain SKU. 

Yes, I know why you want this, but I think you should do it slightly
differently.

> Are you certain that b43 can operate
> well on channels not in their regulatory domain SKU? If so then how about a wiphy flag
> to let drivers pick this.

I don't see a need for a flag. We just need to have the driver set
orig_flags rather than cfg80211, no?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]