Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Jouni Malinen <Jouni.Malinen@Atheros.com>
Subject: Re: [PATCH] mac80211: Reconfigure beacons after a merge run in	IBSS mode
Date: Mon, 19 Jan 2009 09:56:28 +0100	[thread overview]
Message-ID: <1232355388.3799.12.camel@johannes> (raw)
In-Reply-To: <18804.16004.937429.850079@gargle.gargle.HOWL>

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

On Mon, 2009-01-19 at 14:19 +0530, Sujith wrote:
> Johannes Berg wrote:
> > I think instead we should have an enable-beacon flag that we disable
> > before scanning, and then re-enable after scanning like here. That way,
> > we also don't need any extra code in the driver to stop beaconing before
> > scanning, and it generally helps too when userspace deletes the beacon
> > we stop beaconing in a controlled fashion.
> 
> Yep, I did remember the earlier discussion, this seemed like a quick fix
> for my IBSS troubles :)

:)
How do you disable beaconing to start with though?

> > The best way is probably to add a conf flag like CONF_PS and a change
> > flag for this, what do you think?
> 
> This has to be a per-interface flag, so it would be part of ieee80211_if_conf ?

Right, of course, sorry. And I don't care whether you add a flags field
or a bool beacon_enabled ;)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2009-01-19  8:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-19  7:35 [PATCH] mac80211: Reconfigure beacons after a merge run in IBSS mode Sujith
2009-01-19  8:29 ` Johannes Berg
2009-01-19  8:49   ` Sujith
2009-01-19  8:56     ` Johannes Berg [this message]
2009-01-19  9:23       ` Sujith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232355388.3799.12.camel@johannes \
    --to=johannes@sipsolutions.net \
    --cc=Jouni.Malinen@Atheros.com \
    --cc=Sujith.Manoharan@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox