From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] iwl3945: fix some warnings when compiled without debug
Date: Mon, 19 Jan 2009 11:09:06 +0100 [thread overview]
Message-ID: <1232359746.3758.0.camel@johannes> (raw)
In-Reply-To: <200901190955.04622.helmut.schaa@gmail.com> (sfid-20090119_100256_705388_7BA8EF01)
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
On Mon, 2009-01-19 at 09:55 +0100, Helmut Schaa wrote:
> Fix the following warnings if compiled without CONFIG_IWLWIFI_DEBUG.
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c: In function ‘iwl3945_rx_reply_add_sta’:
> drivers/net/wireless/iwlwifi/iwl3945-base.c:2748: warning: unused variable ‘pkt’
> drivers/net/wireless/iwlwifi/iwl3945-base.c: In function ‘iwl3945_rx_scan_results_notif’:
> drivers/net/wireless/iwlwifi/iwl3945-base.c:2903: warning: unused variable ‘notif’
> drivers/net/wireless/iwlwifi/iwl3945-base.c: In function ‘iwl3945_rx_scan_complete_notif’:
> drivers/net/wireless/iwlwifi/iwl3945-base.c:2928: warning: unused variable ‘scan_notif’
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> index b437cac..15d36d8 100644
> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> @@ -2744,7 +2744,9 @@ static void iwl3945_rx_reply_alive(struct iwl_priv *priv,
> static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
> struct iwl_rx_mem_buffer *rxb)
> {
> + #ifdef CONFIG_IWLWIFI_DEBUG
> struct iwl_rx_packet *pkt = (void *)rxb->skb->data;
> + #endif
I for one would definitely prefer you didn't indent preprocessor
statements, but I don't care all that much about iwl3945.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-19 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 8:55 [PATCH 1/2] iwl3945: fix some warnings when compiled without debug Helmut Schaa
2009-01-19 10:09 ` Johannes Berg [this message]
2009-01-19 11:59 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232359746.3758.0.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox