From: Johannes Berg <johannes@sipsolutions.net>
To: Rami Rosen <ramirose@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
luisca@cozybit.com
Subject: Re: [PATCH 4/4] mac80211: use IEEE80211_IFSTA_MESH_CTR_INC macro to increment ttl.
Date: Mon, 19 Jan 2009 12:59:43 +0100 [thread overview]
Message-ID: <1232366383.3864.0.camel@johannes.local> (raw)
In-Reply-To: <eb3ff54b0901190350w5ca5c3d0ocadbaa3c6cbac747@mail.gmail.com> (sfid-20090119_125114_759642_CD8FF056)
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Mon, 2009-01-19 at 13:50 +0200, Rami Rosen wrote:
> This patch replaces decrementing ttl explicitly with the
> IEEE80211_IFSTA_MESH_CTR_INC macro in mesh_hwmp.c
>
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> --
> (wireless-testing)
>
> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> index 4f862b2..1828d80 100644
> --- a/net/mac80211/mesh_hwmp.c
> +++ b/net/mac80211/mesh_hwmp.c
> @@ -507,7 +507,7 @@ static void hwmp_prep_frame_process(struct
> ieee80211_sub_if_data *sdata,
>
> ttl = PREP_IE_TTL(prep_elem);
> if (ttl <= 1) {
> - sdata->u.mesh.mshstats.dropped_frames_ttl++;
> + IEEE80211_IFSTA_MESH_CTR_INC(&sdata->u.mesh,dropped_frames_ttl);
For one, this is whitespace damaged, secondly, it's not necessary to use
the macro in a mesh-only file.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-01-19 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 11:50 [PATCH 4/4] mac80211: use IEEE80211_IFSTA_MESH_CTR_INC macro to increment ttl Rami Rosen
2009-01-19 11:59 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232366383.3864.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luisca@cozybit.com \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox