Re: [PATCH] mac80211: Add capability to enable/disable beaconing

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

cOn Tue, 2009-01-20 at 13:27 +0530, Sujith wrote:
> This patch adds a flag to notify drivers to start and
> stop beaconing when needed, for example, during a scan run.


> +	if ((changed & IEEE80211_IFCC_BEACON) &&
> +	    (sdata->vif.type == NL80211_IFTYPE_AP ||
> +	     sdata->vif.type == NL80211_IFTYPE_ADHOC ||
> +	     sdata->vif.type == NL80211_IFTYPE_MESH_POINT)) {
> +		if (local->sw_scanning || local->hw_scanning)
> +			conf.enable_beacon = false;
> +		else
> +			conf.enable_beacon = true;
> +	}
> +

You really just want to do the minimal thing, right? :)

That won't work when userspace disables the beacon by removing it, for
instance, right now drivers won't know when hostapd removed the beacon
except that ieee80211_beacon_get will start returning 0... Also, I think
a separate change flag would be appropriate, sometimes we might just
re-enable the beacon without having changed it, after scanning?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]