* [PATCH] ath9k: Fix typo in chip version check
@ 2009-01-21 11:48 Vasanthakumar Thiagarajan
2009-01-21 16:48 ` [ath9k-devel] " Pavel Roskin
0 siblings, 1 reply; 2+ messages in thread
From: Vasanthakumar Thiagarajan @ 2009-01-21 11:48 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis.Rodriguez, Jouni.Malinen, ath9k-devel
Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
---
drivers/net/wireless/ath9k/hw.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath9k/hw.c b/drivers/net/wireless/ath9k/hw.c
index ab15e55..baa7a7e 100644
--- a/drivers/net/wireless/ath9k/hw.c
+++ b/drivers/net/wireless/ath9k/hw.c
@@ -2255,7 +2255,7 @@ int ath9k_hw_reset(struct ath_hal *ah, struct ath9k_channel *chan,
return -EINVAL;
}
- if (AR_SREV_9280(ah)) {
+ if (AR_SREV_9280_10_OR_LATER(ah)) {
REG_SET_BIT(ah, AR_GPIO_INPUT_EN_VAL,
AR_GPIO_JTAG_DISABLE);
--
1.5.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [ath9k-devel] [PATCH] ath9k: Fix typo in chip version check
2009-01-21 11:48 [PATCH] ath9k: Fix typo in chip version check Vasanthakumar Thiagarajan
@ 2009-01-21 16:48 ` Pavel Roskin
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Roskin @ 2009-01-21 16:48 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan
Cc: linville, ath9k-devel, Jouni.Malinen, linux-wireless,
Luis.Rodriguez
Hello, Vasanthakumar!
On Wed, 2009-01-21 at 17:18 +0530, Vasanthakumar Thiagarajan wrote:
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> ---
> drivers/net/wireless/ath9k/hw.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
I'm not a developer of ath9k, and I don't know much about the hardware.
However, I think your patch should be better explained.
> - if (AR_SREV_9280(ah)) {
> + if (AR_SREV_9280_10_OR_LATER(ah)) {
It's not a typo. A typo would be something like AR_SREV_9380, that is
never defined. Or maybe a message like "foudn AR9280". AR_SREV_9280 is
defined and has valid uses. If you think it needs to be changed in this
particular case, an explanation is needed. It would be nice if you
mentioned that it fixes something for some hardware.
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-21 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-21 11:48 [PATCH] ath9k: Fix typo in chip version check Vasanthakumar Thiagarajan
2009-01-21 16:48 ` [ath9k-devel] " Pavel Roskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).