From: Pavel Roskin <proski@gnu.org>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: orinoco-devel@lists.sourceforge.net, linux-wireless@vger.kernel.org
Subject: Re: [Orinoco-devel] [PATCH] orinoco: trivial cleanup in alloc_orinocodev
Date: Wed, 21 Jan 2009 15:21:32 -0500 [thread overview]
Message-ID: <1232569292.10843.13.camel@dv> (raw)
In-Reply-To: <200901212155.32754.arvidjaar@mail.ru>
On Wed, 2009-01-21 at 21:55 +0300, Andrey Borzenkov wrote:
> Subject: [PATCH] orinoco: trivial cleanup in alloc_orinocodev
> From: Andrey Borzenkov <arvidjaar@mail.ru>
>
> Remove extra space; remove redundant cast
>
> Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
Signed-off-by: Pavel Roskin <proski@gnu.org>
> - if (! dev)
> + if (!dev)
There are 41 occurrences of "(! " in drivers/net/wireless, all in
drivers/net/wireless/orinoco. Care to fix them all?
By the way, I made a patch that adds all C sources in
drivers/net/wireless/orinoco and ran it through checkpatch.pl. There
were 226 errors and 174 warnings. That includes those spaces, trailing
whitespace, excessively long lines and so on. It would be great if you
fix at least some of that. Actually, long lines are justified in many
cases, so please don't overdo it.
> - dev->wireless_handlers = (struct iw_handler_def *)&orinoco_handler_def;
> + dev->wireless_handlers = &orinoco_handler_def;
That's fine.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-01-21 20:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 18:55 [PATCH] orinoco: trivial cleanup in alloc_orinocodev Andrey Borzenkov
2009-01-21 20:21 ` Pavel Roskin [this message]
2009-01-21 20:32 ` [Orinoco-devel] " Dave
2009-01-21 20:46 ` Pavel Roskin
2009-01-22 9:19 ` Kalle Valo
2009-01-22 16:33 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232569292.10843.13.camel@dv \
--to=proski@gnu.org \
--cc=arvidjaar@mail.ru \
--cc=linux-wireless@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).