From: Johannes Berg <johannes@sipsolutions.net>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net, "Abbas,
Mohamed" <mohamed.abbas@intel.com>
Subject: Re: [PATCH 1/2 v2.6.29] iwlwifi: fix rs_get_rate WARN_ON()
Date: Thu, 22 Jan 2009 11:57:33 +0100 [thread overview]
Message-ID: <1232621853.30174.19.camel@johannes.local> (raw)
In-Reply-To: <1232564283-18008-2-git-send-email-reinette.chatre@intel.com> (sfid-20090121_195542_734853_62E08E0F)
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Wed, 2009-01-21 at 10:58 -0800, Reinette Chatre wrote:
> From: Abbas, Mohamed <mohamed.abbas@intel.com>
>
> In ieee80211_sta structure there is u64 supp_rates[IEEE80211_NUM_BANDS]
> this is filled with all support rate from assoc_resp. If we associate
> with G-band AP only supp_rates of G-band will be set the other band
> supp_rates will be set to 0. If the user type this command
> this will cause mac80211 to set to new channel, mac80211
> does not disassociate in setting new channel, so the active
> band is now A-band. then in handling the new essid mac80211 will
> kick in the assoc steps which involve sending disassociation frame.
> in this mac80211 will WARN_ON sta->supp_rates[A_BAND] == 0.
Sounds like we should fix mac80211 to disassociate _before_ switching
the channel? It won't help anyway if we're on another channel?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-22 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 18:58 [PATCH 0/2 v2.6.29] iwlwifi driver fixes for 2.6.29 Reinette Chatre
2009-01-21 18:58 ` [PATCH 1/2 v2.6.29] iwlwifi: fix rs_get_rate WARN_ON() Reinette Chatre
2009-01-21 18:58 ` [PATCH 2/2 v2.6.29] iwlagn: fix agn rate scaling Reinette Chatre
2009-01-23 19:01 ` John W. Linville
2009-01-23 19:28 ` reinette chatre
2009-01-23 19:55 ` [ipw3945-devel] " Tomas Winkler
2009-01-23 20:01 ` John W. Linville
2009-01-22 10:57 ` Johannes Berg [this message]
2009-01-22 16:51 ` [PATCH 1/2 v2.6.29] iwlwifi: fix rs_get_rate WARN_ON() Abbas, Mohamed
2009-01-25 16:29 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232621853.30174.19.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mohamed.abbas@intel.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).