[PATCH] CRDA 0.1.0: Fix building with --as-needed

[PATCH] CRDA 0.1.0: Fix building with --as-needed

[Tony Vroon]

[-- Attachment #1.1: Type: text/plain, Size: 218 bytes --]

It seems mails from Flameeyes just do not make it through to
linux-wireless, so there it is. Please apply this and consider releasing
1.0.1 (without a v in the tarball name, if at all possible).

Thanks,
Tony V.

[-- Attachment #1.2: Forwarded message - [PATCH] Fix building with --as-needed. --]
[-- Type: message/rfc822, Size: 3761 bytes --]

From: "Diego Elio 'Flameeyes' Pettenò" <flameeyes@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: "Tony Vroon" <tony@linx.net>, "Diego E. 'Flameeyes' Pettenò" <flameeyes@gmail.com>
Subject: [PATCH] Fix building with --as-needed.
Date: Sat, 24 Jan 2009 17:50:31 +0100
Message-ID: <1232815831-6437-1-git-send-email-flameeyes@gmail.com>

From: Diego E. 'Flameeyes' Pettenò <flameeyes@gmail.com>

For --as-needed to work (and for traditional ld too) the libraries should
always be passed _after_ the object files, move them so that they are
picked up properly.

Also rename LIBS to NLLIBS to avoid confusion between LIBS/LDLIBS.
---
 Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index a07fbcf..aaa9ca6 100644
--- a/Makefile
+++ b/Makefile
@@ -48,11 +48,11 @@ endif
 
 ifeq ($(NL2FOUND),Y)
 CFLAGS += -DCONFIG_LIBNL20
-LIBS += -lnl-genl
+NLLIBS += -lnl-genl
 NLLIBNAME = libnl-2.0
 endif
 
-LIBS += `pkg-config --libs $(NLLIBNAME)`
+NLLIBS += `pkg-config --libs $(NLLIBNAME)`
 CFLAGS += `pkg-config --cflags $(NLLIBNAME)`
 
 ifeq ($(V),1)
@@ -85,7 +85,7 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
 
 crda: reglib.o crda.o
 	$(NQ) '  LD  ' $@
-	$(Q)$(CC) $(CFLAGS) $(LDFLAGS) $(LIBS) -o $@ $^ $(LDLIBS)
+	$(Q)$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(NLLIBS)
 
 regdbdump: reglib.o regdbdump.o print-regdom.o
 	$(NQ) '  LD  ' $@
-- 
1.6.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] CRDA 0.1.0: Fix building with --as-needed

[Luis R. Rodriguez]

On Sat, Jan 24, 2009 at 11:54:55AM -0800, Tony Vroon wrote:
> It seems mails from Flameeyes just do not make it through to
> linux-wireless, so there it is. Please apply this and consider releasing
> 1.0.1 (without a v in the tarball name, if at all possible).

Thanks! Can you please resend without signing the patch e-mail?

http://wireless.kernel.org/en/developers/Documentation/SubmittingPatches#Priortosendingpatches

  Luis