From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <bcopeland@gmail.com>
Cc: Alina Friedrichsen <x-alina@gmx.net>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] ath5k: Set TSF fix
Date: Sun, 25 Jan 2009 17:45:17 +0100 [thread overview]
Message-ID: <1232901917.3837.0.camel@johannes.local> (raw)
In-Reply-To: <b6c5339f0901250841r22635bd7q40532891293a6744@mail.gmail.com> (sfid-20090125_174113_839483_F2509A6D)
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Sun, 2009-01-25 at 11:41 -0500, Bob Copeland wrote:
> On Sat, Jan 24, 2009 at 3:12 AM, Alina Friedrichsen <x-alina@gmx.net> wrote:
> > {
> > ATH5K_TRACE(ah->ah_sc);
> >
> > - ath5k_hw_reg_write(ah, 0x00000000, AR5K_TSF_L32);
> > - ath5k_hw_reg_write(ah, (tsf64 >> 32) & 0xffffffff, AR5K_TSF_U32);
> > ath5k_hw_reg_write(ah, tsf64 & 0xffffffff, AR5K_TSF_L32);
> > + ath5k_hw_reg_write(ah, (tsf64 >> 32) & 0xffffffff, AR5K_TSF_U32);
> > }
>
> Perhaps there is an internal latch on this pair; that may explain why
> you need to write low->high order.
Either way, I think the changelog should back up the claim by
_something_. Even if it's just "tested on device XXX, old way doesn't
work, new way does" or "looked at legacy HAL code" or ...
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-25 16:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 8:12 [PATCH] ath5k: Set TSF fix Alina Friedrichsen
2009-01-25 16:41 ` Bob Copeland
2009-01-25 16:45 ` Johannes Berg [this message]
2009-01-25 16:47 ` Bob Copeland
2009-01-26 14:01 ` Alina Friedrichsen
2009-01-27 21:25 ` John W. Linville
-- strict thread matches above, loose matches on Subject: below --
2009-03-02 22:29 Alina Friedrichsen
2009-03-02 22:44 ` Bob Copeland
2009-03-02 23:02 ` Alina Friedrichsen
2009-03-02 23:31 ` Bob Copeland
2009-03-03 21:45 ` Alina Friedrichsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232901917.3837.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=bcopeland@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=x-alina@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).