From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/7 v2] airo: cleanups and simplifications
Date: Tue, 27 Jan 2009 11:41:50 -0500 [thread overview]
Message-ID: <1233074510.25367.9.camel@localhost.localdomain> (raw)
In-Reply-To: <1233047115.4012.10.camel@johannes.local>
On Tue, 2009-01-27 at 10:05 +0100, Johannes Berg wrote:
> On Fri, 2009-01-23 at 17:15 -0500, Dan Williams wrote:
> > airo needs some hot sexy love. come and get your love come and get your
> > love now.
>
> Still needs some!
What are you using to generate the warnings below? I couldn't get them
with C=2 and sparse...
Dan
>
> +drivers/net/wireless/airo.c:3846:8: warning: symbol 'i' shadows an earlier one
> +drivers/net/wireless/airo.c:3757:6: originally declared here
> +drivers/net/wireless/airo.c:3853:8: warning: symbol 'i' shadows an earlier one
> +drivers/net/wireless/airo.c:3757:6: originally declared here
> +drivers/net/wireless/airo.c:3867:7: warning: symbol 'i' shadows an earlier one
> +drivers/net/wireless/airo.c:3757:6: originally declared here
> +drivers/net/wireless/airo.c:1315:33: warning: restricted degrades to integer
> +drivers/net/wireless/airo.c:2056:10: warning: incorrect type in assignment (different base types)
> +drivers/net/wireless/airo.c:2056:10: expected restricted unsigned short [usertype] status
> +drivers/net/wireless/airo.c:2056:10: got unsigned short [unsigned] [usertype] status
> +drivers/net/wireless/airo.c:2108:14: warning: incorrect type in initializer (different signedness)
> +drivers/net/wireless/airo.c:2108:14: expected unsigned int [usertype] *fids
> +drivers/net/wireless/airo.c:2108:14: got int *<noident>
> +drivers/net/wireless/airo.c:2132:14: warning: incorrect type in initializer (different signedness)
> +drivers/net/wireless/airo.c:2132:14: expected unsigned int [usertype] *fids
> +drivers/net/wireless/airo.c:2132:14: got int *<noident>
> +drivers/net/wireless/airo.c:2173:14: warning: incorrect type in initializer (different signedness)
> +drivers/net/wireless/airo.c:2173:14: expected unsigned int [usertype] *fids
> +drivers/net/wireless/airo.c:2173:14: got int *<noident>
> +drivers/net/wireless/airo.c:2197:14: warning: incorrect type in initializer (different signedness)
> +drivers/net/wireless/airo.c:2197:14: expected unsigned int [usertype] *fids
> +drivers/net/wireless/airo.c:2197:14: got int *<noident>
> +drivers/net/wireless/airo.c:3211:11: warning: cast to restricted type
>
> johannes
next prev parent reply other threads:[~2009-01-27 16:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 22:15 [PATCH 0/7 v2] airo: cleanups and simplifications Dan Williams
2009-01-24 14:04 ` [PATCH 1/7 v2] airo: clean up and clarify interrupt-time task handling Dan Williams
2009-01-24 14:10 ` [PATCH 2/7 v2] airo: re-arrange WPA capability checks Dan Williams
2009-01-24 14:11 ` [PATCH 3/7 v2] airo: simplify WEP index and " Dan Williams
2009-01-24 14:12 ` [PATCH 4/7 v2] airo: clean up WEP key operations Dan Williams
2009-01-24 14:12 ` [PATCH 5/7 v2] airo: use __attribute__ ((packed)) not #pragma Dan Williams
2009-01-24 14:13 ` [PATCH 6/7 v2] airo: clean up and clarify micinit() Dan Williams
2009-01-24 14:13 ` [PATCH 7/7 v2] airo: remove useless #defines Dan Williams
2009-01-27 9:05 ` [PATCH 0/7 v2] airo: cleanups and simplifications Johannes Berg
2009-01-27 16:41 ` Dan Williams [this message]
2009-01-27 17:08 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233074510.25367.9.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).