From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kalle.valo@nokia.com>
Cc: "vivek.natraj@gmail.com" <vivek.natraj@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC PATCH v2 2/2] mac80211: use ps-poll when dynamic power save mode is disabled
Date: Thu, 29 Jan 2009 19:32:21 +0100 [thread overview]
Message-ID: <1233253941.4067.2.camel@johannes.local> (raw)
In-Reply-To: <4981F232.5000801@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Thu, 2009-01-29 at 20:15 +0200, Kalle Valo wrote:
> > No, I mean in the timeout > 0 case, what vivek mentioned too. We never
> > go back to sleep unless we send a packet.
>
> First of all, this patchset doesn't change the logic for timeout > 0
> case. But that case was working already earlier, here's my analysis:
>
> 1. tim bit is set
> 2. if timeout > 0 disable power save and send null frame
> 3. null frame enables dynamic_ps_timer in ieee80211_master_start_xmit()
> 4. after dynamic_ps_timer triggers, power save is enabled again
>
> I understood that this was the reason why Vivek moved the running of
> dynamic_ps_timer from subif to the master interface. Or did I miss
> something?
Hah, no, you're right, sorry, I got confused.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-01-29 18:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 11:45 [RFC PATCH v2 0/2] mac80211: ps-poll implementation Kalle Valo
2009-01-22 11:45 ` [RFC PATCH v2 1/2] mac80211: remove multicast check from check_tim() Kalle Valo
2009-01-28 14:59 ` Vivek Natarajan
2009-01-28 16:06 ` Kalle Valo
2009-01-22 11:45 ` [RFC PATCH v2 2/2] mac80211: use ps-poll when dynamic power save mode is disabled Kalle Valo
2009-01-22 17:02 ` Johannes Berg
2009-01-28 16:49 ` Kalle Valo
2009-01-28 18:52 ` Johannes Berg
2009-01-29 18:15 ` Kalle Valo
2009-01-29 18:32 ` Johannes Berg [this message]
2009-01-29 20:19 ` Kalle Valo
2009-01-23 23:28 ` Tomas Winkler
2009-01-28 8:39 ` Kalle Valo
2009-01-28 11:46 ` Tomas Winkler
2009-01-28 12:33 ` Kalle Valo
2009-01-28 13:00 ` Johannes Berg
2009-01-28 13:26 ` Tomas Winkler
2009-01-28 13:36 ` Johannes Berg
2009-01-22 13:00 ` [RFC PATCH v2 0/2] mac80211: ps-poll implementation Johannes Berg
2009-01-23 9:31 ` Kalle Valo
2009-01-23 22:11 ` Johannes Berg
2009-01-28 16:40 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233253941.4067.2.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=kalle.valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).