From: reinette chatre <reinette.chatre@intel.com>
To: Danny Kukawka <dkukawka@suse.de>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Helmut Schaa <hschaa@suse.de>
Subject: Re: [PATCH] fix led device naming for iwl driver
Date: Thu, 29 Jan 2009 11:41:21 -0800 [thread overview]
Message-ID: <1233258081.2411.65.camel@rc-desk> (raw)
In-Reply-To: <200901292029.34976.dkukawka@suse.de>
On Thu, 2009-01-29 at 11:29 -0800, Danny Kukawka wrote:
> From: Danny Kukawka <dkukawka@suse.de>
> Subject: fix led device naming for iwl driver
>
> Fixed led device naming for the iwl driver. Due to the
> documentation of the led subsystem/class the naming should be
> "devicename:colour:function" while not applying sections
> should be left blank.
>
> This should lead to e.g. "iwl-phy0::RX" instead of "iwl-phy0:RX".
>
> Signed-off-by: Danny Kukawka <dkukawka@suse.de>
Sorry - I missed this in your original submission. The subject does not
identify iwlwifi. Subject could be:
iwlwifi: fix led naming
Looks good otherwise.
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
It may be easier for John if you resubmit with the correct subject - you
can just add my ack when you do.
Thanks
Reinette
prev parent reply other threads:[~2009-01-29 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 19:29 [PATCH] fix led device naming for iwl driver Danny Kukawka
2009-01-29 19:41 ` reinette chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233258081.2411.65.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=dkukawka@suse.de \
--cc=hschaa@suse.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox