* [PATCH] wireless: pos[4] tested twice, 2nd should be pos[5]
@ 2009-02-03 16:15 Roel Kluin
2009-02-03 16:39 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-02-03 16:15 UTC (permalink / raw)
To: johannes, dcbw; +Cc: libertas-dev, linux-wireless
Is this what it should be? please review.
----------------->8----------------------8<------------------
pos[4] can't be both 0x43 and 0x04, 2nd should be pos[5]
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/wireless/libertas/scan.c b/drivers/net/wireless/libertas/scan.c
index 57f6c12..00a57ed 100644
--- a/drivers/net/wireless/libertas/scan.c
+++ b/drivers/net/wireless/libertas/scan.c
@@ -692,7 +692,7 @@ static int lbs_process_bss(struct bss_descriptor *bss,
bss->wpa_ie_len);
} else if (pos[1] >= MARVELL_MESH_IE_LENGTH &&
pos[2] == 0x00 && pos[3] == 0x50 &&
- pos[4] == 0x43 && pos[4] == 0x04) {
+ pos[4] == 0x43 && pos[5] == 0x04) {
lbs_deb_scan("got mesh IE\n");
bss->mesh = 1;
} else {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] wireless: pos[4] tested twice, 2nd should be pos[5]
2009-02-03 16:15 [PATCH] wireless: pos[4] tested twice, 2nd should be pos[5] Roel Kluin
@ 2009-02-03 16:39 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2009-02-03 16:39 UTC (permalink / raw)
To: Roel Kluin; +Cc: johannes, libertas-dev, linux-wireless
On Tue, 2009-02-03 at 17:15 +0100, Roel Kluin wrote:
> Is this what it should be? please review.
> ----------------->8----------------------8<------------------
>
> pos[4] can't be both 0x43 and 0x04, 2nd should be pos[5]
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> diff --git a/drivers/net/wireless/libertas/scan.c b/drivers/net/wireless/libertas/scan.c
> index 57f6c12..00a57ed 100644
> --- a/drivers/net/wireless/libertas/scan.c
> +++ b/drivers/net/wireless/libertas/scan.c
> @@ -692,7 +692,7 @@ static int lbs_process_bss(struct bss_descriptor *bss,
> bss->wpa_ie_len);
> } else if (pos[1] >= MARVELL_MESH_IE_LENGTH &&
> pos[2] == 0x00 && pos[3] == 0x50 &&
> - pos[4] == 0x43 && pos[4] == 0x04) {
> + pos[4] == 0x43 && pos[5] == 0x04) {
> lbs_deb_scan("got mesh IE\n");
> bss->mesh = 1;
> } else {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-03 16:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-03 16:15 [PATCH] wireless: pos[4] tested twice, 2nd should be pos[5] Roel Kluin
2009-02-03 16:39 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).