linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Kilroy <kilroyd@googlemail.com>
To: linux-wireless@vger.kernel.org, orinoco-devel@lists.sourceforge.net
Cc: David Kilroy <kilroyd@googlemail.com>
Subject: [PATCH 08/17] orinoco: use orinoco_private instead of net_device in scan helper
Date: Tue,  3 Feb 2009 20:40:30 +0000	[thread overview]
Message-ID: <1233693639-8608-9-git-send-email-kilroyd@googlemail.com> (raw)
In-Reply-To: <1233693639-8608-8-git-send-email-kilroyd@googlemail.com>

This makes the interface to the scan helpers consistent, so we can split
them out.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
---
 drivers/net/wireless/orinoco/main.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/orinoco/main.c b/drivers/net/wireless/orinoco/main.c
index d772e53..1ad1bdf 100644
--- a/drivers/net/wireless/orinoco/main.c
+++ b/drivers/net/wireless/orinoco/main.c
@@ -1929,11 +1929,10 @@ static void orinoco_add_ext_scan_result(struct orinoco_private *priv,
 	}
 }
 
-static int orinoco_process_scan_results(struct net_device *dev,
+static int orinoco_process_scan_results(struct orinoco_private *priv,
 					unsigned char *buf,
 					int len)
 {
-	struct orinoco_private *priv = netdev_priv(dev);
 	int			offset;		/* In the scan data */
 	union hermes_scan_info *atom;
 	int			atom_len;
@@ -1967,7 +1966,8 @@ static int orinoco_process_scan_results(struct net_device *dev,
 			/* Sanity check for atom_len */
 			if (atom_len < sizeof(struct prism2_scan_apinfo)) {
 				printk(KERN_ERR "%s: Invalid atom_len in scan "
-				       "data: %d\n", dev->name, atom_len);
+				       "data: %d\n", priv->ndev->name,
+				       atom_len);
 				return -EIO;
 			}
 		} else
@@ -1980,7 +1980,7 @@ static int orinoco_process_scan_results(struct net_device *dev,
 	/* Check that we got an whole number of atoms */
 	if ((len - offset) % atom_len) {
 		printk(KERN_ERR "%s: Unexpected scan data length %d, "
-		       "atom_len %d, offset %d\n", dev->name, len,
+		       "atom_len %d, offset %d\n", priv->ndev->name, len,
 		       atom_len, offset);
 		return -EIO;
 	}
@@ -2187,7 +2187,7 @@ static void __orinoco_ev_info(struct net_device *dev, hermes_t *hw)
 		}
 #endif	/* ORINOCO_DEBUG */
 
-		if (orinoco_process_scan_results(dev, buf, len) == 0) {
+		if (orinoco_process_scan_results(priv, buf, len) == 0) {
 			/* Send an empty event to user space.
 			 * We don't send the received data on the event because
 			 * it would require us to do complex transcoding, and
-- 
1.6.0.6


  reply	other threads:[~2009-02-03 20:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 20:40 [PATCH 00/17] orinoco: reorganisation David Kilroy
2009-02-03 20:40 ` [PATCH 01/17] orinoco: checkpatch cleanup David Kilroy
2009-02-03 20:40   ` [PATCH 02/17] orinoco: address leading and trailing whitespace David Kilroy
2009-02-03 20:40     ` [PATCH 03/17] orinoco: spaces in parenthesised expressions David Kilroy
2009-02-03 20:40       ` [PATCH 04/17] orinoco: remove unnecessary braces David Kilroy
2009-02-03 20:40         ` [PATCH 05/17] orinoco: keep line length below 80 characters David Kilroy
2009-02-03 20:40           ` [PATCH 06/17] orinoco: Fix interesting checkpatch errors David Kilroy
2009-02-03 20:40             ` [PATCH 07/17] orinoco: Rename orinoco.c David Kilroy
2009-02-03 20:40               ` David Kilroy [this message]
2009-02-03 20:40                 ` [PATCH 09/17] orinoco: Move scan helpers to a separate file David Kilroy
2009-02-03 20:40                   ` [PATCH 10/17] orinoco: Move MIC helpers into new file David Kilroy
2009-02-03 20:40                     ` [PATCH 11/17] orinoco: Move firmware handling into a separate file David Kilroy
2009-02-03 20:40                       ` [PATCH 12/17] orinoco: Use accessor functions for bitrate tables David Kilroy
2009-02-03 20:40                         ` [PATCH 13/17] orinoco: Add hardware function to set multicast mode David Kilroy
2009-02-03 20:40                           ` [PATCH 14/17] orinoco: Move hardware functions into separate file David Kilroy
2009-02-03 20:40                             ` [PATCH 15/17] orinoco: Move WEXT handlers into a " David Kilroy
2009-02-03 20:40                               ` [PATCH 16/17] orinoco: hermes_dld does not need to be a module David Kilroy
2009-02-03 20:40                                 ` [PATCH 17/17] orinoco: hermes doesn't need to be a separate module David Kilroy
2009-02-04 19:34 ` [PATCH 00/17] orinoco: reorganisation Dave

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233693639-8608-9-git-send-email-kilroyd@googlemail.com \
    --to=kilroyd@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=orinoco-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).