From: Johannes Berg <johannes@sipsolutions.net>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: soft-safe -> soft-unsafe lock order detected
Date: Thu, 12 Feb 2009 11:16:47 +0100 [thread overview]
Message-ID: <1234433807.16004.88.camel@johannes.local> (raw)
In-Reply-To: <4991AC67.90104@openwrt.org> (sfid-20090210_173417_726855_7504F887)
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
> to a soft-irq-unsafe lock:
> (todo_lock){--..}
> ... which became soft-irq-unsafe at:
> ... [<800b2248>] __lock_acquire+0x624/0x844
> [<800b24c4>] lock_acquire+0x5c/0x84
> [<8006b8c4>] _spin_lock+0x34/0x48
> [<c0206d9c>] ieee80211_set_default_key+0x4b8/0x4f0 [mac80211]
That seems to be incorrect. ieee80211_set_default_key will have
_irqsave-locked the key lock, so the todo lock is here always locked in
an irq-excluded section.
The lock is, however, possibly used that way in ieee80211_key_link,
which can be fixed easily and we can remove the todo lock too.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-02-12 10:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 16:33 soft-safe -> soft-unsafe lock order detected Gabor Juhos
2009-02-12 10:05 ` Johannes Berg
2009-02-12 10:16 ` Johannes Berg [this message]
2009-02-12 10:24 ` Johannes Berg
2009-02-12 12:56 ` Gabor Juhos
2009-02-12 13:17 ` Johannes Berg
2009-02-12 13:33 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234433807.16004.88.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).