From: Johannes Berg <johannes@sipsolutions.net>
To: Daniel Wagner <wagi@monom.org>
Cc: Dan Williams <dcbw@redhat.com>,
linux-wireless@vger.kernel.org, networkmanager-list@gnome.org
Subject: Re: NetworkManager and mac80211_hwsim
Date: Wed, 18 Feb 2009 09:35:59 +0100 [thread overview]
Message-ID: <1234946159.4149.0.camel@johannes.local> (raw)
In-Reply-To: <20090218080636.GA25504@toronto053.server4you.de>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
On Wed, 2009-02-18 at 09:06 +0100, Daniel Wagner wrote:
> + if (parent_dev != NULL) {
> + hal_device_property_set_string (d, "info.parent", hal_device_get_udi (parent_dev));
> + hal_device_property_set_string (d, "net.originating_device", hal_device_get_udi (parent_dev));
> + } else {
> + hal_device_property_set_string (d, "info.parent", "/org/freedesktop/Hal/devices/computer");
> + hal_device_property_set_string (d, "net.originating_device", "/org/freedesktop/Hal/devices/computer");
> + hal_device_property_set_string (d, "info.linux.driver", "mac80211_hwsim");
> + parent_dev = hal_device_store_find (hald_get_gdl (), "/org/freedesktop/Hal/devices/computer");
> + hal_device_property_set_string (parent_dev, "info.linux.driver", "mac80211");
> + }
This is actually not _that_ bad an idea, because it makes sure everybody
else will properly link up their parent pointer in sysfs. An alternative
that doesn't guarantee that would be to check "is it in the ieee80211
class".
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-02-18 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 16:00 NetworkManager and mac80211_hwsim Daniel Wagner
2009-02-16 16:04 ` Johannes Berg
2009-02-16 17:25 ` Daniel Wagner
2009-02-16 18:00 ` Dan Williams
2009-02-18 8:06 ` Daniel Wagner
2009-02-18 8:35 ` Johannes Berg [this message]
2009-02-19 7:01 ` Daniel Wagner
2009-02-19 14:17 ` Kevin Wilson
2009-02-19 17:20 ` Daniel Wagner
2009-02-20 14:57 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234946159.4149.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=dcbw@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=networkmanager-list@gnome.org \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).