Re: [RFC PATCH v1 3/3] mac80211: add beacon filtering support

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On Mon, 2009-02-23 at 18:37 +0200, Kalle Valo wrote:

> +void ieee80211_beacon_loss_work(struct work_struct *work)
> +{
> +	struct ieee80211_sub_if_data *sdata =
> +		container_of(work, struct ieee80211_sub_if_data,
> +			     u.mgd.beacon_loss_work);
> +
> +	printk(KERN_DEBUG "%s: beacon loss from AP %pM "
> +	       "- disassociating\n", sdata->dev->name, sdata->u.mgd.bssid);
> +
> +	ieee80211_set_disassoc(sdata, true, true,
> +			       WLAN_REASON_PREV_AUTH_NOT_VALID);
> +}

We used to go through a probe request cycle once to make sure, but I'm
not sure there's a point in that. Just pointing out the change here.

The code looks pretty good, but this will lead to an interesting
situation where "iwlist wlan1 scan last" ("iw dev wlan1 scan dump") will
not show _any_ BSS, which will probably trip up NM; this happens because
the BSS will not be updated and expire after 10 seconds. I think we need
a way to "hold on" to the BSS.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]