* [PATCH] iwl3945: re-add iwl_poll_direct_bit return value check
@ 2009-02-24 2:45 Jason Andryuk
2009-02-24 3:12 ` Jason Andryuk
0 siblings, 1 reply; 2+ messages in thread
From: Jason Andryuk @ 2009-02-24 2:45 UTC (permalink / raw)
To: linux-wireless, John W. Linville, reinette chatre
Re-add the iwl_poll_direct_bit return value assignment dropped in Commit
3fdd4102abceb4c99c5091674047b5c61fd3ebba "iwl3945: add apm ops".
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
--
diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
index 6ae0df5..0a75053 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
@@ -1073,7 +1073,7 @@ static int iwl3945_apm_init(struct iwl_priv *priv)
* D0U* --> D0A* state */
iwl_set_bit(priv, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_INIT_DONE);
- iwl_poll_direct_bit(priv, CSR_GP_CNTRL,
+ ret = iwl_poll_direct_bit(priv, CSR_GP_CNTRL,
CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY, 25000);
if (ret < 0) {
IWL_DEBUG_INFO(priv, "Failed to init the card\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iwl3945: re-add iwl_poll_direct_bit return value check
2009-02-24 2:45 [PATCH] iwl3945: re-add iwl_poll_direct_bit return value check Jason Andryuk
@ 2009-02-24 3:12 ` Jason Andryuk
0 siblings, 0 replies; 2+ messages in thread
From: Jason Andryuk @ 2009-02-24 3:12 UTC (permalink / raw)
To: linux-wireless; +Cc: John W. Linville, reinette chatre
On Mon, 2009-02-23 at 21:45 -0500, Jason Andryuk wrote:
> Re-add the iwl_poll_direct_bit return value assignment dropped in Commit
> 3fdd4102abceb4c99c5091674047b5c61fd3ebba "iwl3945: add apm ops".
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> --
grep iwl_poll_direct_bit drivers/net/wireless/iwlwifi/*3945*.c
drivers/net/wireless/iwlwifi/iwl-3945.c: ret = iwl_poll_direct_bit(priv, CSR_GP_CNTRL,
drivers/net/wireless/iwlwifi/iwl-3945.c: iwl_poll_direct_bit(priv, FH39_TSSR_TX_STATUS,
drivers/net/wireless/iwlwifi/iwl-3945.c: iwl_poll_direct_bit(priv, CSR_RESET,
drivers/net/wireless/iwlwifi/iwl-3945.c: iwl_poll_direct_bit(priv, CSR_GP_CNTRL,
drivers/net/wireless/iwlwifi/iwl-3945.c: rc = iwl_poll_direct_bit(priv, FH39_RSSR_STATUS,
Including this patch, only two out of five return values are checked.
It isn't clear to me how errors should be handled in all cases, so a
maintainer should probably take a look at these.
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-24 3:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-24 2:45 [PATCH] iwl3945: re-add iwl_poll_direct_bit return value check Jason Andryuk
2009-02-24 3:12 ` Jason Andryuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).