From: Jason Andryuk <jandryuk@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>,
reinette chatre <reinette.chatre@intel.com>
Subject: Re: [PATCH] iwl3945: re-add iwl_poll_direct_bit return value check
Date: Mon, 23 Feb 2009 22:12:31 -0500 [thread overview]
Message-ID: <1235445152.6365.3.camel@rainbow> (raw)
In-Reply-To: <1235443534.7047.28.camel@rainbow>
On Mon, 2009-02-23 at 21:45 -0500, Jason Andryuk wrote:
> Re-add the iwl_poll_direct_bit return value assignment dropped in Commit
> 3fdd4102abceb4c99c5091674047b5c61fd3ebba "iwl3945: add apm ops".
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> --
grep iwl_poll_direct_bit drivers/net/wireless/iwlwifi/*3945*.c
drivers/net/wireless/iwlwifi/iwl-3945.c: ret = iwl_poll_direct_bit(priv, CSR_GP_CNTRL,
drivers/net/wireless/iwlwifi/iwl-3945.c: iwl_poll_direct_bit(priv, FH39_TSSR_TX_STATUS,
drivers/net/wireless/iwlwifi/iwl-3945.c: iwl_poll_direct_bit(priv, CSR_RESET,
drivers/net/wireless/iwlwifi/iwl-3945.c: iwl_poll_direct_bit(priv, CSR_GP_CNTRL,
drivers/net/wireless/iwlwifi/iwl-3945.c: rc = iwl_poll_direct_bit(priv, FH39_RSSR_STATUS,
Including this patch, only two out of five return values are checked.
It isn't clear to me how errors should be handled in all cases, so a
maintainer should probably take a look at these.
Jason
prev parent reply other threads:[~2009-02-24 3:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 2:45 [PATCH] iwl3945: re-add iwl_poll_direct_bit return value check Jason Andryuk
2009-02-24 3:12 ` Jason Andryuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235445152.6365.3.camel@rainbow \
--to=jandryuk@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).