linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: reinette chatre <reinette.chatre@intel.com>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] iwl3945: initialize is_valid_rtc_data_addr function pointer
Date: Mon, 23 Feb 2009 21:07:28 -0800	[thread overview]
Message-ID: <1235452048.23783.9.camel@rc-desk> (raw)
In-Reply-To: <1235443410.7047.25.camel@rainbow>

On Mon, 2009-02-23 at 18:43 -0800, Jason Andryuk wrote:
> Initialize is_valid_rtc_data_addr function pointer for iwl3945 to
> prevent a NULL pointer dereference in iwl_dump_nic_error_log.
> 
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> --
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index d49e48b..6ae0df5 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -2747,6 +2747,7 @@ static struct iwl_lib_ops iwl3945_lib = {
>  		.query_addr = iwlcore_eeprom_query_addr,
>  	},
>  	.send_tx_power	= iwl3945_send_tx_power,
> +	.is_valid_rtc_data_addr = iwl3945_hw_valid_rtc_data_addr,
>  };
>  
>  static struct iwl_hcmd_utils_ops iwl3945_hcmd_utils = {
> 

Thank you very much

Acked-by: Reinette Chatre <reinette.chatre@intel.com>


Reinette



      reply	other threads:[~2009-02-24  5:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-24  2:43 [PATCH] iwl3945: initialize is_valid_rtc_data_addr function pointer Jason Andryuk
2009-02-24  5:07 ` reinette chatre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1235452048.23783.9.camel@rc-desk \
    --to=reinette.chatre@intel.com \
    --cc=jandryuk@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).