Re: [PATCH wireless-testing] airo_cs: checkpatch.pl cleanups

[Joe Perches <joe@perches.com>]

On Wed, 2009-03-04 at 16:24 -0800, John Daiker wrote:
> Hopefully nothing controversial here, since the driver hasn't been touched in a while!
> 
> Before: 36 errors, 6 warnings, 482 lines checked
> After:  0 errors, 3 warnings, 485 lines checked
> 
> This was nearly all trailing whitespace, * and parenthesis spacing, and code indent changes.
> 
> md5sum of object file before and after are identical.
> 
> ---
> 
> Signed-off-by: John Daiker <daikerjohn@gmail.com>
> 
> diff --git a/drivers/net/wireless/airo_cs.c b/drivers/net/wireless/airo_cs.c
> index 27696c2..6b96add 100644
> --- a/drivers/net/wireless/airo_cs.c
> +++ b/drivers/net/wireless/airo_cs.c
> @@ -16,8 +16,8 @@
>      In addition this module was derived from dummy_cs.
>      The initial developer of dummy_cs is David A. Hinds
>      <dahinds@users.sourceforge.net>.  Portions created by David A. Hinds
> -    are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.    
> -    
> +    are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
> +
>  ======================================================================*/
>  
>  #ifdef __IN_PCMCIA_PACKAGE__
> @@ -38,7 +38,7 @@
>  #include <pcmcia/cisreg.h>
>  #include <pcmcia/ds.h>
>  
> -#include <asm/io.h>
> +#include <linux/io.h>
>  #include <asm/system.h>
>  
>  #include "airo.h"
> @@ -54,7 +54,7 @@
>  static int pc_debug = PCMCIA_DEBUG;
>  module_param(pc_debug, int, 0);
>  static char *version = "$Revision: 1.2 $";
> -#define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args);
> +#define DEBUG(n, args...) if (pc_debug > (n)) printk(KERN_DEBUG args);
>  #else
>  #define DEBUG(n, args...)
>  #endif
> @@ -63,7 +63,7 @@ static char *version = "$Revision: 1.2 $";
>  
>  MODULE_AUTHOR("Benjamin Reed");
>  MODULE_DESCRIPTION("Support for Cisco/Aironet 802.11 wireless
> ethernet \
> -                   cards.  This is the module that links the PCMCIA
> card \
> +		   cards.  This is the module that links the PCMCIA card \
>  		   with the airo module.");

This should use " at the start and end of every line.

MODULE_DESCRIPTION("Support for Cisco/Aironet 802.11 wireless ethernet "
		   "cards.  This is the module that links the PCMCIA card "
		   "with the airo module.");