Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	Jouni.Malinen@Atheros.com
Subject: Re: [PATCH] mac80211: Update IBSS beacon timestamp properly
Date: Sun, 08 Mar 2009 13:52:50 +0100	[thread overview]
Message-ID: <1236516770.4205.17.camel@johannes.local> (raw)
In-Reply-To: <18860.46550.551064.448896@gargle.gargle.HOWL>

[-- Attachment #1: Type: text/plain, Size: 2129 bytes --]

On Tue, 2009-03-03 at 10:15 +0530, Sujith wrote:
> In IBSS mode, the beacon timestamp has to be filled with the
> BSS's timestamp when joining, and set to zero when creating
> a new BSS.

I don't quite understand why, do we read it out again at any point?

johannes

> Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
> ---
>  net/mac80211/ibss.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> index a96ce9d..f4becc1 100644
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -64,7 +64,7 @@ static int __ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
>  				     const int freq,
>  				     const size_t supp_rates_len,
>  				     const u8 *supp_rates,
> -				     const u16 capability)
> +				     const u16 capability, u64 tsf)
>  {
>  	struct ieee80211_if_ibss *ifibss = &sdata->u.ibss;
>  	struct ieee80211_local *local = sdata->local;
> @@ -127,6 +127,7 @@ static int __ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
>  	memcpy(mgmt->bssid, ifibss->bssid, ETH_ALEN);
>  	mgmt->u.beacon.beacon_int =
>  		cpu_to_le16(local->hw.conf.beacon_int);
> +	mgmt->u.beacon.timestamp = cpu_to_le64(tsf);
>  	mgmt->u.beacon.capab_info = cpu_to_le16(capability);
>  
>  	pos = skb_put(skb, 2 + ifibss->ssid_len);
> @@ -199,7 +200,8 @@ static int ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
>  					 bss->cbss.beacon_interval,
>  					 bss->cbss.channel->center_freq,
>  					 bss->supp_rates_len, bss->supp_rates,
> -					 bss->cbss.capability);
> +					 bss->cbss.capability,
> +					 bss->cbss.tsf);
>  }
>  
>  static void ieee80211_rx_bss_info(struct ieee80211_sub_if_data *sdata,
> @@ -502,7 +504,7 @@ static int ieee80211_sta_create_ibss(struct ieee80211_sub_if_data *sdata)
>  					 bssid, local->hw.conf.beacon_int,
>  					 local->hw.conf.channel->center_freq,
>  					 sband->n_bitrates, supp_rates,
> -					 capability);
> +					 capability, 0);
>  }
>  
>  static int ieee80211_sta_find_ibss(struct ieee80211_sub_if_data *sdata)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2009-03-08 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03  4:45 [PATCH] mac80211: Update IBSS beacon timestamp properly Sujith
2009-03-08 12:52 ` Johannes Berg [this message]
2009-03-08 13:04   ` Sujith
2009-03-08 13:08     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236516770.4205.17.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=Jouni.Malinen@Atheros.com \
    --cc=Sujith.Manoharan@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox