From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/4] mac80211: disallow HT40 if max channel bandwidth is less than 40 MHz
Date: Tue, 10 Mar 2009 08:15:29 +0100 [thread overview]
Message-ID: <1236669329.9658.30.camel@johannes.local> (raw)
In-Reply-To: <1236650699-30538-4-git-send-email-lrodriguez@atheros.com>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
On Mon, 2009-03-09 at 22:04 -0400, Luis R. Rodriguez wrote:
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> net/mac80211/util.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index 32610a0..a891d7e 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -796,6 +796,9 @@ int ieee80211_set_freq(struct ieee80211_sub_if_data *sdata, int freqMHz)
> if (!chan || (chan->flags & IEEE80211_CHAN_DISABLED))
> return ret;
>
> + if (conf_is_ht40(&local->hw.conf) && chan->max_bandwidth < 40)
> + return ret;
> +
You just made nl80211 check this, why bother adding it here too?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-03-10 7:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 2:04 [PATCH 0/4] wireless: use channel bandwidth Luis R. Rodriguez
2009-03-10 2:04 ` [PATCH 1/4] cfg80211: check allowed channel max bandwidth before setting HT40 Luis R. Rodriguez
2009-03-10 2:04 ` [PATCH 2/4] mac80211: move early error branch check on ieee80211_set_freq() Luis R. Rodriguez
2009-03-10 2:04 ` [PATCH 3/4] mac80211: disallow HT40 if max channel bandwidth is less than 40 MHz Luis R. Rodriguez
2009-03-10 7:15 ` Johannes Berg [this message]
2009-03-10 8:43 ` Luis R. Rodriguez
2009-03-10 8:46 ` Johannes Berg
2009-03-10 8:51 ` Luis R. Rodriguez
2009-03-10 2:04 ` [PATCH 4/4] cfg80211: send channel max bandwidth to userspace Luis R. Rodriguez
2009-03-10 7:16 ` [PATCH 0/4] wireless: use channel bandwidth Johannes Berg
2009-03-10 8:43 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236669329.9658.30.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox