Re: [PATCH v2] mac80211: Tear down aggregation sessions for suspend/resume

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

On Mon, 2009-03-16 at 16:04 +0530, Sujith wrote:
> Johannes Berg wrote:
> > On Mon, 2009-03-16 at 15:20 +0530, Sujith wrote:
> > > When the driver has been notified with a STA_REMOVE, it tears down
> > > the internal ADDBA state. On resume, trying to initiate aggregation would
> > > fail because mac80211 has not cleared the operational state for that <TID,STA>.
> > > This can be fixed by tearing down the existing sessions on a suspend.
> > > 
> > > Also, the driver can initiate a new BA session when suspend is in progress.
> > > This is fixed by marking the station as being in suspend state and
> > > denying ADDBA requests for such STAs.
> > > 
> > > Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
> > 
> > Looks good to me, thanks. Should we really set a per-station flag
> > though? It seems a "local->suspended" would be sufficient and much
> > cheaper?
> 
> I did consider it, but then was unsure of the locking required.
> If that can be clarified, I will change this to be a ieee80211_local variable.

Good catch, that does seem a little complicated. This way is good
anyway, so let's stick to it, at least for now.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]