From: Johannes Berg <johannes@sipsolutions.net>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Jouni.Malinen@Atheros.com, me@bobcopeland.com
Subject: Re: [PATCH v2] mac80211: Tear down aggregation sessions for suspend/resume
Date: Mon, 16 Mar 2009 15:02:42 +0100 [thread overview]
Message-ID: <1237212162.16396.15.camel@johannes.local> (raw)
In-Reply-To: <18878.9292.503830.420780@gargle.gargle.HOWL>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On Mon, 2009-03-16 at 15:35 +0530, Sujith wrote:
> + /* Tear down aggregation sessions */
> + if (hw->flags & IEEE80211_HW_AMPDU_AGGREGATION) {
> + list_for_each_entry(sta, &local->sta_list, list) {
> + set_sta_flags(sta, WLAN_STA_SUSPEND);
> + ieee80211_sta_tear_down_BA_sessions(sta);
> + }
> + }
Doesn't that, and the corresponding code in resume, need to be using the
rcu-safe list iteration primitives and rcu_read_lock(), or acquire the
sta_lock like the other iteration? While we should be more or less
quiescent at this point, I wouldn't really want to bet on it.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-03-16 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 10:05 [PATCH v2] mac80211: Tear down aggregation sessions for suspend/resume Sujith
2009-03-16 14:02 ` Johannes Berg [this message]
2009-03-16 18:20 ` Sujith
-- strict thread matches above, loose matches on Subject: below --
2009-03-16 9:50 Sujith
2009-03-16 10:11 ` Johannes Berg
2009-03-16 10:34 ` Sujith
2009-03-16 10:53 ` Johannes Berg
2009-03-16 14:18 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237212162.16396.15.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=Jouni.Malinen@Atheros.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).