From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: drop wext channel list if too long
Date: Mon, 16 Mar 2009 12:56:51 -0400 [thread overview]
Message-ID: <1237222611.16956.17.camel@localhost.localdomain> (raw)
In-Reply-To: <1237019432.5235.61.camel@johannes.local>
On Sat, 2009-03-14 at 09:30 +0100, Johannes Berg wrote:
> On Fri, 2009-03-13 at 13:18 -0400, Dan Williams wrote:
>
> > It doesn't look like wpa_supplicant cares about the returned channel
> > list from SIOCGIWRANGE.
> >
> > NM, however, uses the returned channel list to figure out a free
> > supported adhoc frequency to use when creating an adhoc network (like
> > for connection sharing). If it can't find an intersection between an
> > internal "safe" frequency list and what the card supports (which it
> > wouldn't be able to with this patch), it will simply use 2462 or 5180
> > MHz.
> >
> > Thus, I don't think you'll *break* anything specifically, but this patch
> > would cause the default frequency for an IBSS created by NM to move
> > from channel 1 to channel 11.
>
> In that case, let's just drop the patch, I have no problem with that.
>
> We just couldn't figure out why some channels were missing in iwlist
> when they were in iw, but that's due to the 32 channel limit. Since most
> people probably don't use this particular functionality, I guess it
> doesn't really matter. Eventually NM should just use nl80211, or at
> least try to, because there it gets more information like "cannot do
> IBSS on channel XY", something that wext doesn't give you, but mac80211
> enforces.
Yup; nl80211 is the way to go here. Or better yet, make wpa_supplicant
card capabilities over D-Bus so NM doesn't have to touch the driver
directly.
Dan
prev parent reply other threads:[~2009-03-16 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 18:24 [PATCH] cfg80211: drop wext channel list if too long Johannes Berg
2009-03-13 14:54 ` John W. Linville
2009-03-13 17:18 ` Dan Williams
2009-03-14 8:30 ` Johannes Berg
2009-03-16 16:56 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237222611.16956.17.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).