linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: Antonio Marques <froz@icix.org>,
	Andrey Yurovsky <andrey@cozybit.com>,
	linux-wireless@vger.kernel.org
Subject: Re: rt2x00 mesh support
Date: Wed, 18 Mar 2009 14:12:52 +0100	[thread overview]
Message-ID: <1237381972.5100.21.camel@johannes.local> (raw)
In-Reply-To: <200903181348.51609.IvDoorn@gmail.com> (sfid-20090318_134925_116254_40D04E2C)

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

On Wed, 2009-03-18 at 13:48 +0100, Ivo van Doorn wrote:

> Excellent thanks. :)
> 
> Johannes, my previous assumption is apparently correct,
> The following is happening:
> 
> ieee80211_open()
> 	-> ops->add_interface()
> 	-> ieee80211_start_mesh()
> 		->  ieee80211_if_config()
> 			-> ops->config_interface()
> 	-> ieee80211_hw_config()
> 		-> ops->config()
> 
> Because config_interface() is called before config() the radio
> is not enabled at the moment config_interface() is called and
> the call to config() will effectively disable beaconing.

Ah. I thought you were saying ->start() came after ->config_interface(),
->config() coming after it makes no sense either but we haven't even
tried to avoid that so far... In fact, it is perfectly legal for
->config() to be called after ->config_interface() when, for example,
you change the channel. Not that I disagree -- we should be setting the
beacon interval before enabling beaconing...

What exactly is the problem here? The fact that we don't enable the
radio until after having configured beaconing? I'm not sure how to solve
this, to be honest.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2009-03-18 13:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-23 18:58 rt2x00 mesh support Antonio Marques
2009-01-23 19:02 ` Andrey Yurovsky
2009-01-24 11:40   ` António Marques
2009-03-15 11:54     ` Antonio Marques
2009-03-15 13:45       ` Ivo van Doorn
2009-03-16  1:58         ` Pat Erley
2009-03-16 13:29           ` Antonio Marques
2009-03-16 13:22         ` António Marques
2009-03-16 14:58           ` Ivo van Doorn
2009-03-16 19:12             ` Antonio Marques
2009-03-17  9:31               ` Ivo van Doorn
2009-03-17 14:11                 ` Johannes Berg
2009-03-17 20:10                   ` Johannes Berg
2009-03-17 21:50                     ` Ivo van Doorn
2009-03-17 21:53                       ` Johannes Berg
2009-03-17 22:04                         ` Ivo van Doorn
2009-03-17 22:35                           ` Johannes Berg
2009-03-17 23:01                             ` Ivo van Doorn
2009-03-17 23:04                               ` Johannes Berg
2009-03-18 10:02                                 ` Ivo van Doorn
2009-03-18 12:26                                   ` Antonio Marques
2009-03-18 12:48                                     ` Ivo van Doorn
2009-03-18 13:12                                       ` Johannes Berg [this message]
2009-03-18 13:31                                         ` Ivo van Doorn
2009-03-18 13:36                                           ` Johannes Berg
2009-03-19 21:55                                             ` Antonio Marques
2009-03-17 19:38                 ` Antonio Marques
2009-03-17 22:03                   ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237381972.5100.21.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=andrey@cozybit.com \
    --cc=froz@icix.org \
    --cc=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).