From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: linville@tuxdriver.com, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, Quentin@armitage.org.uk,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
stable@kernel.org
Subject: [PATCH 2/5] cfg80211: fix incorrect assumption on last_request for 11d
Date: Fri, 20 Mar 2009 23:53:05 -0400 [thread overview]
Message-ID: <1237607588-6316-3-git-send-email-lrodriguez@atheros.com> (raw)
In-Reply-To: <1237607588-6316-1-git-send-email-lrodriguez@atheros.com>
The incorrect assumption is the last regulatory request
(last_request) is always a country IE when processing
country IEs. Although this is true 99% of the time the
first time this happens this could not be true.
This fixes an oops in the branch check for the last_request
when accessing drv_last_ie. The access was done under the
assumption the struct won't be null.
Note to stable: to port to 29 replace as follows, only 29 has
country IE code:
s|NL80211_REGDOM_SET_BY_COUNTRY_IE|REGDOM_SET_BY_COUNTRY_IE
Cc: stable@kernel.org
Reported-by: Quentin Armitage <Quentin@armitage.org.uk>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/wireless/reg.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index ead9dcc..9afc916 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -1601,6 +1601,10 @@ static bool reg_same_country_ie_hint(struct wiphy *wiphy,
assert_cfg80211_lock();
+ if (unlikely(last_request->initiator !=
+ NL80211_REGDOM_SET_BY_COUNTRY_IE))
+ return false;
+
request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx);
if (!request_wiphy)
@@ -1663,7 +1667,9 @@ void regulatory_hint_11d(struct wiphy *wiphy,
* we optimize an early check to exit out early if we don't have to
* do anything
*/
- if (likely(wiphy_idx_valid(last_request->wiphy_idx))) {
+ if (likely(last_request->initiator ==
+ NL80211_REGDOM_SET_BY_COUNTRY_IE &&
+ wiphy_idx_valid(last_request->wiphy_idx))) {
struct cfg80211_registered_device *drv_last_ie;
drv_last_ie =
--
1.6.0.6
next prev parent reply other threads:[~2009-03-21 3:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-21 3:53 [PATCH 0/5] cfg80211: few reg fixes and removes OLD_REG Luis R. Rodriguez
2009-03-21 3:53 ` [PATCH 1/5] cfg80211: force last_request to be set for OLD_REG if regdom is EU Luis R. Rodriguez
2009-03-21 3:53 ` Luis R. Rodriguez [this message]
2009-03-21 3:53 ` [PATCH 3/5] cfg80211: make regdom module parameter available oustide of OLD_REG Luis R. Rodriguez
2009-03-21 3:53 ` [PATCH 4/5] cfg80211: remove code about country IE support with OLD_REG Luis R. Rodriguez
2009-03-21 3:53 ` [PATCH 5/5] cfg80211: remove CONFIG_WIRELESS_OLD_REGULATORY Luis R. Rodriguez
2009-03-21 14:23 ` [PATCH 0/5] cfg80211: few reg fixes and removes OLD_REG Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237607588-6316-3-git-send-email-lrodriguez@atheros.com \
--to=lrodriguez@atheros.com \
--cc=Quentin@armitage.org.uk \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox