public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH v2] mac80211: resume properly, add suspend/resume test
Date: Sat, 21 Mar 2009 08:59:43 +0100	[thread overview]
Message-ID: <1237622383.5100.162.camel@johannes.local> (raw)
In-Reply-To: <20090320160308.GB28965@jm.kir.nu>

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

On Fri, 2009-03-20 at 18:03 +0200, Jouni Malinen wrote:
> On Fri, Mar 13, 2009 at 11:44:18AM +0100, Johannes Berg wrote:
> 
> > --- wireless-testing.orig/net/mac80211/debugfs.c	2009-03-13 11:36:57.000000000 +0100
> > +++ wireless-testing/net/mac80211/debugfs.c	2009-03-13 11:41:53.000000000 +0100
> > +static ssize_t reset_write(struct file *file, const char __user *user_buf,
> > +			   size_t count, loff_t *ppos)
> 
> > +	__ieee80211_suspend(&local->hw);
> > +	__ieee80211_resume(&local->hw);
> 
> This seems to have broken build if CONFIG_PM is not defined: pm.c, with
> these functions, is not included.

Indeed, this file should depend on CONFIG_PM too I suppose, will fix
that. OTOH, a future patch I have will require _resume to always be
present, so I'm inclined to just always put the code in. I'll come up
with a fix in any case.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2009-03-21  7:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13 10:25 [PATCH] mac80211: resume properly, add suspend/resume test Johannes Berg
2009-03-13 10:44 ` [PATCH v2] " Johannes Berg
2009-03-13 10:48   ` Johannes Berg
2009-03-13 10:50     ` Johannes Berg
2009-03-13 12:10       ` Helmut Schaa
2009-03-13 12:15         ` Johannes Berg
2009-03-13 10:58     ` Johannes Berg
2009-03-13 18:51       ` Bob Copeland
2009-03-13 21:19         ` Johannes Berg
2009-03-20 16:03   ` Jouni Malinen
2009-03-21  7:59     ` Johannes Berg [this message]
2009-03-23 19:43       ` John W. Linville
2009-03-23 19:50         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237622383.5100.162.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=buytenh@wantstofly.org \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox