From: Johannes Berg <johannes@sipsolutions.net>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org,
hs4233@mail.mn-solutions.de
Subject: Re: [PATCH] Marvell CF8381
Date: Sun, 22 Mar 2009 09:04:08 +0100 [thread overview]
Message-ID: <1237709048.5100.682.camel@johannes.local> (raw)
In-Reply-To: <200903220511.50229.marek.vasut@gmail.com> (sfid-20090322_051148_655459_21864B2F)
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
On Sun, 2009-03-22 at 05:11 +0100, Marek Vasut wrote:
> One more thing - I also had to apply the following patch in order to get
> region code detected properly.
>
> le16_to_cpu(cmd.regioncode) = 0x3031 for me and Im definitelly not in spain,
> but 0x30 (eu) looks reasonable.
>
> diff --git a/drivers/net/wireless/libertas/cmd.c
> b/drivers/net/wireless/libertas/cmd.c
> index 639dd02..ce32bc9 100644
> --- a/drivers/net/wireless/libertas/cmd.c
> +++ b/drivers/net/wireless/libertas/cmd.c
> @@ -123,7 +123,7 @@ int lbs_update_hw_spec(struct lbs_private *priv)
> * only ever be 8-bit, even though the field size is 16-bit. Some
> firmware
> * returns non-zero high 8 bits here.
> */
> - priv->regioncode = le16_to_cpu(cmd.regioncode) & 0xFF;
> + priv->regioncode = (le16_to_cpu(cmd.regioncode) & 0xFF00) >> 8;
I'd be more inclined to think that this was an endian bug? Does your
machine happen to be big endian?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-03-22 8:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 0:27 [PATCH] Marvell CF8381 Marek Vasut
2009-03-22 4:11 ` Marek Vasut
2009-03-22 8:04 ` Johannes Berg [this message]
2009-03-22 13:01 ` Marek Vasut
2009-03-22 13:03 ` Johannes Berg
2009-03-23 12:27 ` Holger Schurig
2009-03-23 16:15 ` Dan Williams
2009-03-23 21:58 ` Marek Vasut
2009-03-23 23:08 ` Dan Williams
2009-03-23 23:42 ` Marek Vasut
2009-03-24 10:26 ` Dan Williams
2009-03-24 20:01 ` John W. Linville
2009-03-24 20:33 ` Marek Vasut
2009-03-23 12:13 ` Holger Schurig
2009-03-23 14:34 ` Marek Vasut
2009-03-23 15:57 ` [PATCH1/2] Fix return value handling Marek Vasut
2009-03-23 15:59 ` Marek Vasut
2009-03-23 16:11 ` Dan Williams
2009-03-23 15:59 ` [PATCH] Marvell CF8381 and CF8305 Marek Vasut
2009-03-23 16:00 ` Marek Vasut
2009-03-23 16:06 ` Holger Schurig
2009-03-23 17:09 ` Marek Vasut
2009-03-23 17:19 ` Dan Williams
2009-03-23 17:39 ` Marek Vasut
2009-03-23 16:58 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237709048.5100.682.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).