From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <me@bobcopeland.com>
Cc: Kalle Valo <kalle.valo@iki.fi>,
"Alexander E. Patrakov" <patrakov@gmail.com>,
linux-wireless@vger.kernel.org, mb@bu3sch.de
Subject: Re: Kernel panic with zd1211rw and today's compat-wireless
Date: Mon, 23 Mar 2009 20:56:22 +0100 [thread overview]
Message-ID: <1237838182.6147.20.camel@johannes.local> (raw)
In-Reply-To: <20090323194523.M76544@bobcopeland.com>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Mon, 2009-03-23 at 14:52 -0500, Bob Copeland wrote:
> On Mon, 23 Mar 2009 20:36:28 +0100, Johannes Berg wrote
> > I think I'm in favour of "downgrading" that to a WARN_ON, like this:
> > if (WARN_ON(...))
> > info->control.rates[0].idx = rate_lowest()
> >
> > johannes
>
> How about the similar WARN_ON() in ieee80211_get_tx_rate()? Does
> it make sense to try and tx a frame but return null for the rate
> structure?
Not really, I think. But it should only return NULL if the above
condition was true.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-03-23 19:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 12:45 Kernel panic with zd1211rw and today's compat-wireless Alexander E. Patrakov
2009-03-22 12:56 ` Johannes Berg
2009-03-22 13:15 ` Michael Buesch
2009-03-22 14:49 ` Bob Copeland
2009-03-22 15:09 ` Michael Buesch
2009-03-22 22:04 ` Bob Copeland
2009-03-22 22:12 ` Michael Buesch
2009-03-23 15:08 ` Kalle Valo
2009-03-23 19:36 ` Johannes Berg
2009-03-23 19:52 ` Bob Copeland
2009-03-23 19:56 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237838182.6147.20.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=me@bobcopeland.com \
--cc=patrakov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).