linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: Christian Lamparter <chunkeey@web.de>, Max Filippov <jcmvbkbc@gmail.com>
Subject: [PATCH 2/2] p54spi: fix p54_upload_firmware
Date: Wed, 25 Mar 2009 08:30:16 +0300	[thread overview]
Message-ID: <1237959016-17311-2-git-send-email-jcmvbkbc@gmail.com> (raw)
In-Reply-To: <1237959016-17311-1-git-send-email-jcmvbkbc@gmail.com>

 Instead of firmware itself p54_upload_firmware was sending to the device content of struct firmware
 and the following random garbage. Notice '&' before priv->firmware->data at p54spi_spi_write.
 But simple removing of '&' sign triggered BUG_ON at dma_cache_maint. Thus kmemdup - kfree workaround.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 drivers/net/wireless/p54/p54spi.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/p54/p54spi.c b/drivers/net/wireless/p54/p54spi.c
index d13268f..4ef57c5 100644
--- a/drivers/net/wireless/p54/p54spi.c
+++ b/drivers/net/wireless/p54/p54spi.c
@@ -265,8 +265,15 @@ static int p54spi_upload_firmware(struct ieee80211_hw *dev)
 		p54spi_write32(priv, SPI_ADRS_DMA_WRITE_BASE,
 			       cpu_to_le32(fw_addr));
 
-		p54spi_spi_write(priv, SPI_ADRS_DMA_DATA,
-				 &priv->firmware->data, _fw_len);
+		{
+			void *fw = kmemdup(priv->firmware->data, _fw_len, GFP_KERNEL);
+			if (fw)
+			{
+				p54spi_spi_write(priv, SPI_ADRS_DMA_DATA,
+						 fw, _fw_len);
+				kfree(fw);
+			}
+		}
 
 		fw_len -= _fw_len;
 		fw_addr += _fw_len;
-- 
1.5.4.3


  reply	other threads:[~2009-03-25  5:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25  5:30 [PATCH 1/2] p54spi: mask value read from SPI_ADRS_DMA_WRITE_CTRL in p54spi_wait_bit Max Filippov
2009-03-25  5:30 ` Max Filippov [this message]
2009-03-25 11:21   ` [PATCH 2/2] p54spi: fix p54_upload_firmware Christian Lamparter
2009-03-25 12:00     ` Max Filippov
2009-03-25 12:45       ` [PATCH 2/2 v2] p54spi: fix p54spi_upload_firmware Christian Lamparter
2009-03-25 12:50         ` Max Filippov
2009-03-25 12:56           ` Johannes Berg
2009-03-26  2:26             ` Max Filippov
2009-03-25 13:42           ` Christian Lamparter
2009-03-25 14:34             ` Christian Lamparter
2009-03-26  6:22               ` p54spi - mesh mode summary Max Filippov
2009-03-26  8:12                 ` Johannes Berg
2009-03-27  5:03                   ` Max Filippov
2009-03-27 14:06                     ` Christian Lamparter
2009-03-28  3:21                       ` Max Filippov
2009-03-28 21:51                         ` Christian Lamparter
2009-03-29  4:41                           ` Max Filippov
2009-03-29 13:49                             ` Christian Lamparter
2009-03-30  4:38                               ` Max Filippov
2009-03-26  1:15         ` [PATCH 2/2 v2] p54spi: fix p54spi_upload_firmware Max Filippov
2009-03-25 10:55 ` [PATCH 1/2] p54spi: mask value read from SPI_ADRS_DMA_WRITE_CTRL in p54spi_wait_bit Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237959016-17311-2-git-send-email-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=chunkeey@web.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).