From: Johannes Berg <johannes@sipsolutions.net>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Inaky Perez-Gonzalez <inaky@linux.intel.com>,
Dirk Opfer <Dirk@Opfer-Online.de>,
toshiba_acpi@memebeam.org, Matthew Garrett <mjg@redhat.com>
Subject: Re: [RFC] rfkill: rewrite
Date: Mon, 30 Mar 2009 16:08:34 +0200 [thread overview]
Message-ID: <1238422114.5970.6.camel@johannes.local> (raw)
In-Reply-To: <20090330132911.GC11934@khazad-dum.debian.net>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Mon, 2009-03-30 at 10:29 -0300, Henrique de Moraes Holschuh wrote:
> On Mon, 30 Mar 2009, Johannes Berg wrote:
> > * thinkpad_acpi.c
> > -> need help, convoluted code I don't understand at all, looks like
> > another candidate for rewriting
>
> Heh. I will take care of it, obviously. As for rewriting, well, a cleanup
> is in the queue.
Heh, thanks. I appreciate any help even if the golden rule still is that
those who change the API get to fix users :)
Thinkpad in particular confuses me due to the way it uses force_state
and input. Is it like Dell in that the button press causes a soft block?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-03-30 15:19 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 17:53 [RFC] rfkill: rewrite Johannes Berg
2009-03-29 18:16 ` Ivo van Doorn
2009-03-30 13:27 ` Henrique de Moraes Holschuh
2009-03-30 9:06 ` Johannes Berg
2009-03-30 9:54 ` Michael Buesch
2009-03-30 9:57 ` Johannes Berg
2009-03-30 10:39 ` Johannes Berg
2009-03-30 9:40 ` Johannes Berg
2009-03-30 10:04 ` Matthew Garrett
2009-03-30 13:29 ` Henrique de Moraes Holschuh
2009-03-30 14:08 ` Johannes Berg [this message]
2009-03-30 17:34 ` Henrique de Moraes Holschuh
2009-03-30 17:41 ` Johannes Berg
2009-03-30 20:48 ` Henrique de Moraes Holschuh
2009-03-30 20:52 ` Johannes Berg
2009-03-30 21:02 ` Henrique de Moraes Holschuh
2009-03-30 21:20 ` Johannes Berg
2009-03-30 17:39 ` Inaky Perez-Gonzalez
2009-03-30 17:45 ` Johannes Berg
2009-03-30 17:54 ` Ivo van Doorn
2009-03-30 18:00 ` Johannes Berg
2009-03-30 20:36 ` Inaky Perez-Gonzalez
2009-03-30 20:43 ` Johannes Berg
2009-03-30 20:52 ` Henrique de Moraes Holschuh
2009-03-30 19:01 ` Johannes Berg
2009-03-30 22:07 ` Johannes Berg
2009-03-30 22:08 ` Johannes Berg
2009-03-30 21:15 ` Henrique de Moraes Holschuh
2009-03-30 21:26 ` Johannes Berg
2009-03-30 21:26 ` Johannes Berg
2009-04-05 14:59 ` Henrique de Moraes Holschuh
2009-04-07 10:36 ` Johannes Berg
2009-04-08 18:06 ` Henrique de Moraes Holschuh
2009-04-14 21:03 ` Johannes Berg
2009-03-30 22:16 ` [RFC/RFT v2] " Johannes Berg
2009-03-30 23:20 ` Larry Finger
2009-03-31 8:02 ` Johannes Berg
2009-03-31 8:11 ` Johannes Berg
2009-03-31 12:16 ` Johannes Berg
2009-03-31 18:20 ` Larry Finger
2009-03-31 18:32 ` Johannes Berg
2009-03-31 19:11 ` [RFC v3] " Johannes Berg
2009-04-14 21:48 ` [RFC v5] " Johannes Berg
2009-04-14 23:08 ` [RFC v6] " Johannes Berg
2009-04-15 4:34 ` Larry Finger
2009-04-30 3:19 ` Henrique de Moraes Holschuh
2009-04-30 8:53 ` Johannes Berg
2009-04-30 14:11 ` Henrique de Moraes Holschuh
2009-04-30 14:18 ` Johannes Berg
2009-04-30 15:06 ` Johannes Berg
2009-04-30 15:53 ` Henrique de Moraes Holschuh
2009-04-30 16:09 ` Johannes Berg
2009-04-30 15:14 ` [RFC v8] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238422114.5970.6.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=Dirk@Opfer-Online.de \
--cc=hmh@hmh.eng.br \
--cc=inaky@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=toshiba_acpi@memebeam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).