From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 3/3] cfg80211: send regulatory beacon hint events to userspace
Date: Thu, 02 Apr 2009 03:46:21 +0200 [thread overview]
Message-ID: <1238636782.4141.0.camel@johannes.local> (raw)
In-Reply-To: <1238636130-27747-3-git-send-email-lrodriguez@atheros.com>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On Wed, 2009-04-01 at 21:35 -0400, Luis R. Rodriguez wrote:
> +void nl80211_send_beacon_hint_event(struct wiphy *wiphy,
> + struct ieee80211_channel *channel_before,
> + struct ieee80211_channel *channel_after)
> +{
> +#define NL80211_PUT_BC_CHAN(_attr, _chan) do { \
> + nl_freq = nla_nest_start(msg, _attr); \
> + if (!nl_freq) \
> + goto nla_put_failure; \
> + if (nl80211_msg_put_channel(msg, _chan)); \
> + goto nla_put_failure; \
> + nla_nest_end(msg, nl_freq); \
> +} while (0)
Please just open-code that, and there's a ; too much after the if.
Otherwise good series, thanks.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-04-02 1:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 1:35 [PATCH v3 1/3] cfg80211: respect API on orig_flags on channel for beacon hint Luis R. Rodriguez
2009-04-02 1:35 ` [PATCH v3 2/3] cfg80211: add netlink channel put helper Luis R. Rodriguez
2009-04-02 1:35 ` [PATCH v3 3/3] cfg80211: send regulatory beacon hint events to userspace Luis R. Rodriguez
2009-04-02 1:46 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238636782.4141.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox