From: Richard Purdie <rpurdie@linux.intel.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] leds: Increase trigger name maximum size
Date: Fri, 03 Apr 2009 15:45:04 +0100 [thread overview]
Message-ID: <1238769904.5347.11.camel@dax.rpnet.com> (raw)
In-Reply-To: <49D536FA.2050307@lwfinger.net>
On Thu, 2009-04-02 at 17:06 -0500, Larry Finger wrote:
> Larry Finger wrote:
> > On my HP dv2815 laptop, the total length of the triggers for my b43legacy
> > wireless device exceeds the maximum value of 50 defined in
> > include/linux/leds.h. As a result, the list is garbled.
> >
> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > ---
>
> Richard,
>
> Please drop this. That length change is a red herring. Something is corrupting
> the list of triggers, but this length is not it.
>
> Sorry for the noise.
I was about to raise some concerns about this patch as its just hiding
some underlying memory corruption. I don't think this is related to the
LED code but let me know if it turns out to be.
Cheers,
Richard
--
Richard Purdie
Intel Open Source Technology Centre
prev parent reply other threads:[~2009-04-03 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 18:36 [PATCH] leds: Increase trigger name maximum size Larry Finger
2009-04-02 22:06 ` Larry Finger
2009-04-03 14:45 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238769904.5347.11.camel@dax.rpnet.com \
--to=rpurdie@linux.intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).