From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: mac80211: changing number of queues in ops->start
Date: Tue, 07 Apr 2009 21:46:29 +0200 [thread overview]
Message-ID: <1239133589.7475.3.camel@johannes.local> (raw)
In-Reply-To: <200904072140.23318.mb@bu3sch.de>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
On Tue, 2009-04-07 at 21:40 +0200, Michael Buesch wrote:
> Ok I see. So you say it's OK to lower hw->queues after ieee80211_register.
Let's say it's acceptable ;)
> Should I reset hw->queues back to the value ieee80211_register was called with, before
> I call unregister/free? Are there resources allocated by the number of queues?
There are resources allocated, notably the qdiscs etc. in
alloc_ether_mq() or whatever it's called in register_hw(). But the
networking core should keep track of those so it shouldn't matter what
the value is. OTOH if it can switch back and forth the pending packets
are done per queue... for example ieee80211_clear_tx_pending will be
called at unregister times, so if it's possible to be up with 4 queues,
and later be up with 1, you will want to unregister with 4.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-04-07 19:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 18:24 mac80211: changing number of queues in ops->start Michael Buesch
2009-04-07 19:29 ` Johannes Berg
2009-04-07 19:33 ` Michael Buesch
2009-04-07 19:37 ` Johannes Berg
2009-04-07 19:40 ` Michael Buesch
2009-04-07 19:46 ` Johannes Berg [this message]
2009-04-07 19:51 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239133589.7475.3.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).