From: Dan Williams <dcbw@redhat.com>
To: Philip Rakity <prakity@yahoo.com>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] libertas: don't leak skb on receive error
Date: Wed, 08 Apr 2009 10:23:02 -0400 [thread overview]
Message-ID: <1239200582.14879.5.camel@localhost.localdomain> (raw)
In-Reply-To: <422915.71719.qm@web58908.mail.re1.yahoo.com>
On Tue, 2009-04-07 at 12:41 -0700, Philip Rakity wrote:
>
> Don't lead memory when receive errors
> Signed-off-by: Philip Rakity <prakity@yahoo.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> --- linux-2.6.29/drivers/net/wireless/libertas/rx.c.old 2009-04-01 13:19:26.000000000 -0700
> +++ linux-2.6.29/drivers/net/wireless/libertas/rx.c 2009-04-01 13:19:57.000000000 -0700
> @@ -170,6 +170,7 @@
> lbs_deb_rx("rx err: frame received with bad length\n");
> priv->stats.rx_length_errors++;
> ret = 0;
> + dev_kfree_skb(skb);
> goto done;
> }
>
> @@ -181,6 +182,7 @@
> lbs_pr_alert("rxpd not ok\n");
> priv->stats.rx_errors++;
> ret = 0;
> + dev_kfree_skb(skb);
> goto done;
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-04-08 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 19:41 [PATCH] libertas: don't leak skb on receive error Philip Rakity
2009-04-08 7:26 ` Holger Schurig
2009-04-08 14:23 ` Dan Williams [this message]
2009-04-21 17:39 ` [stable] " Chris Wright
-- strict thread matches above, loose matches on Subject: below --
2009-04-06 22:02 Philip Rakity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239200582.14879.5.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=prakity@yahoo.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).