linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org
Subject: Re: [ath5k-devel] BUG in wiphy_update_regulatory when loading ath5k (on latest git)
Date: Fri, 10 Apr 2009 13:45:33 -0400	[thread overview]
Message-ID: <1239385533.24621.11.camel@mj> (raw)
In-Reply-To: <49DF714F.9070600@tuffmail.co.uk>

On Fri, 2009-04-10 at 17:18 +0100, Alan Jenkins wrote:

> [   65.062652] BUG: unable to handle kernel NULL pointer dereference at
> 00000004
...
> [   65.063330] Code: b8 da 17 e0 83 c0 04 e8 92 f9 ff ff 84 c0 75 2a 8b 
> 55 d4 8b 42 28 85 c0 74 0c 83 c0 04 e8 7c f9 ff ff 84 c0 75 14 a1 bc da 
> 17 e0 <83> 78 04 03 74 66 8b 4d d4 80 79 08 00 74 5d a1 e0 d2 17 e0 48

"<83> 78 04 03" is "cmpl   $0x3,0x4(%rax)", which I can find in
disassemly of reg_is_world_roaming(), which was inlined into
wiphy_update_regulatory().

0x3 is almost certainly NL80211_REGDOM_SET_BY_COUNTRY_IE in
reg_is_world_roaming().  %rax must be 0, so we have a read at address
0x4.

last_request must be NULL.  The "initiator" field is at offset 4, which
is consistent with the assembly.

Thus, wiphy_update_regulatory() is called before last_request was
assigned a value.

last_request only seems to get a value in __regulatory_hint(), which is
ultimately called by reg_todo(), a work handler.

-- 
Regards,
Pavel Roskin

  parent reply	other threads:[~2009-04-10 17:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <49DF6216.8040303@tuffmail.co.uk>
2009-04-10 16:18 ` BUG in wiphy_update_regulatory when loading ath5k (on latest git) Alan Jenkins
2009-04-10 17:15   ` [ath5k-devel] " Luis R. Rodriguez
2009-04-10 17:45   ` Pavel Roskin [this message]
2009-04-10 18:11     ` Luis R. Rodriguez
2009-04-10 20:21       ` Pavel Roskin
2009-04-10 20:30         ` Alan Jenkins
2009-04-10 22:26           ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239385533.24621.11.camel@mj \
    --to=proski@gnu.org \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).